Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2218313002: Revert of Make sure no stale LLD checkout is around. (Closed)

Created:
4 years, 4 months ago by krasin1
Modified:
4 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, yunlian, Reid Kleckner, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, hans, dmikurube+clang_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make sure no stale LLD checkout is around. (patchset #1 id:1 of https://codereview.chromium.org/2220113002/ ) Reason for revert: Breaks clang_upload bot: OSError: [Errno 2] No such file or directory: '/b/build/slave/linux_upload_clang/build/src/third_party/llvm/tools/lld' It seems that RmTree requires the directory to exist. Original issue's description: > Make sure no stale LLD checkout is around. > > We checked out LLD for a while on all platforms, and now some bots > have stale checkouts of it. See bug for details. > > BUG=635108 > > Committed: https://crrev.com/f2e30b8c230d923e61752352cf4c37eb13eea3d2 > Cr-Commit-Position: refs/heads/master@{#410206} TBR=thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635108 Committed: https://crrev.com/d1d17ef355294fe1ad2f624711869003a3ded893 Cr-Commit-Position: refs/heads/master@{#410247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
krasin1
Created Revert of Make sure no stale LLD checkout is around.
4 years, 4 months ago (2016-08-06 01:31:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218313002/1
4 years, 4 months ago (2016-08-06 01:31:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-06 01:32:31 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-06 01:35:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1d17ef355294fe1ad2f624711869003a3ded893
Cr-Commit-Position: refs/heads/master@{#410247}

Powered by Google App Engine
This is Rietveld 408576698