Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: content/browser/ssl/ssl_policy.cc

Issue 2218253002: Stop revoking cert exceptions on resources loaded from cache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clearer comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/ssl/ssl_manager.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/ssl/ssl_policy.cc
diff --git a/content/browser/ssl/ssl_policy.cc b/content/browser/ssl/ssl_policy.cc
index 99d14e558069cb0ccd96a437eb355535da0aeded..9d60c36a8ceb770c6850ca91be149f1910153524 100644
--- a/content/browser/ssl/ssl_policy.cc
+++ b/content/browser/ssl/ssl_policy.cc
@@ -163,7 +163,8 @@ void SSLPolicy::OnRequestStarted(const GURL& url,
if (backend_->HasAllowException(url.host())) {
// If there's no certificate error, a good certificate has been seen, so
// clear out any exceptions that were made by the user for bad
- // certificates.
+ // certificates. This intentionally does not apply to cached resources
+ // (see https://crbug.com/634553 for an explanation).
backend_->RevokeUserAllowExceptions(url.host());
event = HAD_PREVIOUS_EXCEPTION;
}
« no previous file with comments | « content/browser/ssl/ssl_manager.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698