Stop revoking cert exceptions on resources loaded from cache

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <stddef.h>
 
 #include <cmath>
 #include <utility>
@@ skipping 3442 matching lines @@
         GetRenderProcessHost(),
         bad_message::WC_MEMORY_CACHE_RESOURCE_BAD_SECURITY_INFO);
     return;
   }
 
   // Send out a notification that we loaded a resource from our memory cache.
   // TODO(alcutter,eranm): Pass signed_certificate_timestamp_ids into details.
   LoadFromMemoryCacheDetails details(
       url, status.cert_id, status.cert_status, http_method, mime_type,
       resource_type);
-
-  controller_.ssl_manager()->DidLoadFromMemoryCache(details);
-
   FOR_EACH_OBSERVER(WebContentsObserver, observers_,
                     DidLoadResourceFromMemoryCache(details));

[jww, 2016/08/09 02:42:18]

Side question: why isn't SSLManager a WebContentsObserver, given that it seems
to implement several methods that are called identically right before the
WebContentsObserver methods are called? Would it simplify future method changes
if we just made it a WebContentsObserver?

If the answer is 'yes,' definitely not a blocker, but we may want to file a bug.

[felt, 2016/08/10 14:17:18]

That's a great question. I was wondering that too. I don't see any reason why.

 
   if (url.is_valid() && url.SchemeIsHTTPOrHTTPS()) {
     scoped_refptr<net::URLRequestContextGetter> request_context(
         resource_type == RESOURCE_TYPE_MEDIA ?
             GetRenderProcessHost()->GetStoragePartition()->
                 GetMediaURLRequestContext() :
             GetRenderProcessHost()->GetStoragePartition()->
                 GetURLRequestContext());
     BrowserThread::PostTask(
         BrowserThread::IO,
@@ skipping 1754 matching lines @@
   for (RenderViewHost* render_view_host : render_view_host_set)
     render_view_host->OnWebkitPreferencesChanged();
 }
 
 void WebContentsImpl::SetJavaScriptDialogManagerForTesting(
     JavaScriptDialogManager* dialog_manager) {
   dialog_manager_ = dialog_manager;
 }
 
 }  // namespace content