build/android/pylib/device/adb_wrapper.py - Issue 221823011: [Android] Change object types from AndroidCommands to DeviceUtils in build/android/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/device/adb_wrapper.py

Issue 221823011: [Android] Change object types from AndroidCommands to DeviceUtils in build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Frank's comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/pylib/content_settings.py ('K') | « build/android/pylib/content_settings.py ('k') | build/android/pylib/device/adb_wrapper_test.py » ('j') | build/android/pylib/device/device_utils.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/device/adb_wrapper.py

diff --git a/build/android/pylib/device/adb_wrapper.py b/build/android/pylib/device/adb_wrapper.py

index c455ec4c11a95ef165affdf992e7cc214a9c3391..440a02c33564555c52654f904efb57fea97df243 100644

--- a/build/android/pylib/device/adb_wrapper.py

+++ b/build/android/pylib/device/adb_wrapper.py

@@ -39,6 +39,10 @@ class CommandTimeoutError(BaseError):

pass

+class DeviceUnreachableError(BaseError):

+ """Exception for device unreachable failures."""

+ pass

def _VerifyLocalFileExists(path):

"""Verifies a local file exists.

@@ -152,7 +156,7 @@ class AdbWrapper(object):

output = cls._AdbCmd(['devices'], timeout, retries)

lines = [line.split() for line in output.split('\n')]

return [AdbWrapper(line[0]) for line in lines

- if len(line) == 2 and line[1] == 'device']

+ if len(line) == 2 and line[1] == 'device']

def GetDeviceSerial(self):

"""Gets the device serial number associated with this object.