Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 221823007: Add MediaControlTimelineElement FIXME for "timeline offset" (Closed)

Created:
6 years, 8 months ago by philipj_slow
Modified:
6 years, 8 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Add MediaControlTimelineElement FIXME for "timeline offset" The problem was raised but not correctly addressed in https://codereview.chromium.org/219283004/ BUG=312699 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170735

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/html/shadow/MediaControlElements.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
6 years, 8 months ago (2014-04-02 20:43:29 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 8 months ago (2014-04-02 23:00:28 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 8 months ago (2014-04-03 04:53:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/221823007/1
6 years, 8 months ago (2014-04-03 04:53:23 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 05:47:30 UTC) #5
Message was sent while issue was closed.
Change committed as 170735

Powered by Google App Engine
This is Rietveld 408576698