Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: build/common.gypi

Issue 221823004: Disable -Wshorten-64-to-32 when building with Xcode for arm64 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 4328 matching lines...) Expand 10 before | Expand all | Expand 10 after
4339 'OTHER_CFLAGS': [ 4339 'OTHER_CFLAGS': [
4340 '-Xclang', '-add-plugin', '-Xclang', '<(clang_add_plugin)', 4340 '-Xclang', '-add-plugin', '-Xclang', '<(clang_add_plugin)',
4341 ], 4341 ],
4342 }], 4342 }],
4343 ['clang==1 and "<(GENERATOR)"=="ninja"', { 4343 ['clang==1 and "<(GENERATOR)"=="ninja"', {
4344 'OTHER_CFLAGS': [ 4344 'OTHER_CFLAGS': [
4345 # See http://crbug.com/110262 4345 # See http://crbug.com/110262
4346 '-fcolor-diagnostics', 4346 '-fcolor-diagnostics',
4347 ], 4347 ],
4348 }], 4348 }],
4349 ['OS=="ios" and target_subarch!="arm32" and \
4350 "<(GENERATOR)"=="ninja"', {
4351 'OTHER_CFLAGS': [
4352 # TODO(ios): when building Chrome for iOS on 64-bit platform
4353 # with Xcode, the -Wshorted-64-to-32 warning is automatically
4354 # enabled. This cause failures when compiling protobuf code,
4355 # so disable the warning. http://crbug.com/359107
4356 '-Wno-shorten-64-to-32',
4357 ],
4358 }],
4349 ], 4359 ],
4350 }, 4360 },
4351 'conditions': [ 4361 'conditions': [
4352 ['clang==1', { 4362 ['clang==1', {
4353 'variables': { 4363 'variables': {
4354 'clang_dir': '../third_party/llvm-build/Release+Asserts/bin', 4364 'clang_dir': '../third_party/llvm-build/Release+Asserts/bin',
4355 }, 4365 },
4356 }], 4366 }],
4357 ['asan==1', { 4367 ['asan==1', {
4358 'xcode_settings': { 4368 'xcode_settings': {
(...skipping 847 matching lines...) Expand 10 before | Expand all | Expand 10 after
5206 # settings in target dicts. SYMROOT is a special case, because many other 5216 # settings in target dicts. SYMROOT is a special case, because many other
5207 # Xcode variables depend on it, including variables such as 5217 # Xcode variables depend on it, including variables such as
5208 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5218 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5209 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5219 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5210 # files to appear (when present) in the UI as actual files and not red 5220 # files to appear (when present) in the UI as actual files and not red
5211 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5221 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5212 # and therefore SYMROOT, needs to be set at the project level. 5222 # and therefore SYMROOT, needs to be set at the project level.
5213 'SYMROOT': '<(DEPTH)/xcodebuild', 5223 'SYMROOT': '<(DEPTH)/xcodebuild',
5214 }, 5224 },
5215 } 5225 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698