Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 22182002: Measure usage for Text.prototype.replaceWholeText() (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, lgombos
Visibility:
Public.

Description

Measure usage for Text.prototype.replaceWholeText() Measure usage for Text.prototype.replaceWholeText() as it was removed from DOM4: http://www.w3.org/TR/2012/WD-dom-20121206/#text This will allow us to determine if it can be deprecated / removed or whether DOM4 needs to add it back. Note that Firefox has already dropped support for this method. However, IE10 still supports it. R=arv BUG=267521 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155617

Patch Set 1 #

Patch Set 2 : Rebaseline additional test #

Patch Set 3 : Use MeasureAs instead of deprecating #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/dom/Text.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-05 12:35:53 UTC) #1
arv (Not doing code reviews)
LGTM
7 years, 4 months ago (2013-08-05 13:26:39 UTC) #2
do-not-use
On 2013/08/05 13:26:39, arv wrote: > LGTM tkent@, could you please take a look as ...
7 years, 4 months ago (2013-08-06 07:02:28 UTC) #3
tkent
On 2013/08/06 07:02:28, Christophe Dumez wrote: > On 2013/08/05 13:26:39, arv wrote: > > LGTM ...
7 years, 4 months ago (2013-08-06 08:09:01 UTC) #4
do-not-use
On 2013/08/06 08:09:01, tkent wrote: > On 2013/08/06 07:02:28, Christophe Dumez wrote: > > On ...
7 years, 4 months ago (2013-08-06 08:22:54 UTC) #5
tkent
> So use MeasureAs for now instead of DeprecateAs, right? Right.
7 years, 4 months ago (2013-08-06 08:28:19 UTC) #6
do-not-use
On 2013/08/06 08:28:19, tkent wrote: > > So use MeasureAs for now instead of DeprecateAs, ...
7 years, 4 months ago (2013-08-06 08:48:35 UTC) #7
tkent
lgtm
7 years, 4 months ago (2013-08-06 09:21:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22182002/13001
7 years, 4 months ago (2013-08-06 09:49:06 UTC) #9
arv (Not doing code reviews)
This feature is not in Firefox and has been removed from the spec. I think ...
7 years, 4 months ago (2013-08-06 11:34:44 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=1360
7 years, 4 months ago (2013-08-06 12:48:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22182002/13001
7 years, 4 months ago (2013-08-06 15:25:11 UTC) #12
commit-bot: I haz the power
Change committed as 155617
7 years, 4 months ago (2013-08-06 16:57:16 UTC) #13
do-not-use
On 2013/08/06 11:34:44, arv wrote: > This feature is not in Firefox and has been ...
7 years, 4 months ago (2013-08-06 17:37:13 UTC) #14
arv (Not doing code reviews)
Personally I don't think it is needed but me and tkent clearly disagree and he ...
7 years, 4 months ago (2013-08-06 18:12:44 UTC) #15
tkent
7 years, 4 months ago (2013-08-06 22:44:18 UTC) #16
Message was sent while issue was closed.
On 2013/08/06 17:37:13, Christophe Dumez wrote:
> Do you think I should send and "Intent to deprecate" email and see what other
> think about it?

It should be sent when Chrome stable collects the UseCounter data and the
counter number proves the deprecation is reasonable.

Powered by Google App Engine
This is Rietveld 408576698