Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2218173003: Remove duplicate entry from source list (Closed)

Created:
4 years, 4 months ago by zra
Modified:
4 years, 4 months ago
Reviewers:
cbernaschina, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M runtime/observatory/observatory_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
Please watch out for this. It messes up the GN build.
4 years, 4 months ago (2016-08-05 21:10:31 UTC) #2
Cutch
lgtm
4 years, 4 months ago (2016-08-05 21:11:02 UTC) #3
zra
Committed patchset #1 (id:1) manually as 2e3d56a9d616fab70c5ff2d29b9f680692a63bfd.
4 years, 4 months ago (2016-08-05 21:11:32 UTC) #5
cbernaschina
4 years, 4 months ago (2016-08-05 21:11:39 UTC) #6
Message was sent while issue was closed.
On 2016/08/05 21:11:02, Cutch wrote:
> lgtm

lgtm

Powered by Google App Engine
This is Rietveld 408576698