Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2218173002: Revert of Clears GuestModeEnabled and AddPersonEnabled user prefs if MD settings is enabled (Closed)

Created:
4 years, 4 months ago by anthonyvd
Modified:
4 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Clears GuestModeEnabled and AddPersonEnabled user prefs if MD settings is enabled (patchset #4 id:60001 of https://codereview.chromium.org/2207003002/ ) Reason for revert: Reverting this CL because it breaks compile on the following bot: https://build.chromium.org/p/chromium.gpu/builders/GPU%20Mac%20Builder/builds/66935 Original issue's description: > Clears GuestModeEnabled and AddPersonEnabled user prefs if MD settings is enabled. > > MD settings gets rid of the checkboxes that enabled browsing as guest and adding new profiles. This CL clears the two prefs previously set by users. This should have no effect if the prefs are set by policy. > > This logic can be removed once all users' prefs are cleared > > BUG=630100 > > Committed: https://crrev.com/8c440d2c549779305eb5439ae451158e694b5214 > Cr-Commit-Position: refs/heads/master@{#410105} TBR=rogerta@chromium.org,rkaplow@chromium.org,michaelpg@chromium.org,mahmadi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630100 Committed: https://crrev.com/c14818cae6553f32e6c9cb756e58d0831126e4aa Cr-Commit-Position: refs/heads/master@{#410111}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 4 chunks +0 lines, -21 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
anthonyvd
Created Revert of Clears GuestModeEnabled and AddPersonEnabled user prefs if MD settings is enabled
4 years, 4 months ago (2016-08-05 18:12:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218173002/1
4 years, 4 months ago (2016-08-05 18:12:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 18:14:02 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 18:16:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c14818cae6553f32e6c9cb756e58d0831126e4aa
Cr-Commit-Position: refs/heads/master@{#410111}

Powered by Google App Engine
This is Rietveld 408576698