Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 221813010: Sets transient for PrintDialogGtk2 (Closed)

Created:
6 years, 8 months ago by Jun Mukai
Modified:
6 years, 8 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Visibility:
Public.

Description

Sets transient for PrintDialogGtk2 Moves the transient parent utilities to gtk2_util and makes both dialogs use it. This is a reland of r259318 with a fix of test failures. BUG=334331 TBR=erg@chromium.org TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261473

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -28 lines) Patch
M chrome/browser/ui/libgtk2ui/gtk2_util.h View 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_util.cc View 3 chunks +32 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/print_dialog_gtk2.h View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc View 4 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc View 4 chunks +4 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 8 months ago (2014-04-02 23:20:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/221813010/1
6 years, 8 months ago (2014-04-02 23:20:30 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 02:01:16 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=292981
6 years, 8 months ago (2014-04-03 02:01:16 UTC) #4
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 8 months ago (2014-04-03 17:02:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/221813010/1
6 years, 8 months ago (2014-04-03 17:02:57 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 17:56:57 UTC) #7
Message was sent while issue was closed. 
Change committed as 261473

Powered by Google App Engine
This is Rietveld 408576698