Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 221813005: Do not count MemoryCache reference in Resource::hasOneHandle (Closed)

Created:
6 years, 8 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 8 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Visibility:
Public.

Description

Do not count MemoryCache reference in Resource::hasOneHandle BUG=337425 R=japhet@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M Source/core/fetch/Resource.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/fetch/Resource.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dmitry Lomov (no reviews)
Nate, WDYT? This lets a resource be evicted from ResourceFetcher cache when the only other ...
6 years, 8 months ago (2014-04-02 12:19:26 UTC) #1
Nate Chapin
This makes sense, LGTM. Is there a way to test this?
6 years, 8 months ago (2014-04-02 16:52:42 UTC) #2
Dmitry Lomov (no reviews)
The CQ bit was checked by dslomov@chromium.org
6 years, 8 months ago (2014-04-02 19:15:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dslomov@chromium.org/221813005/1
6 years, 8 months ago (2014-04-02 19:15:39 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 20:44:04 UTC) #5
Message was sent while issue was closed.
Change committed as 170698

Powered by Google App Engine
This is Rietveld 408576698