Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2218023002: [x64][ia32] Add Support for the Float64Neg and Float32Neg turbofan operators. (Closed)

Created:
4 years, 4 months ago by ahaas
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64][ia32] Add Support for the Float64Neg and Float32Neg turbofan operators. Benedikt, do you think we could also provide these operators on mips, maybe by expanding them to "-0.0 -x"? If mips can provide these operators, then we could make Float64Neg and Float32Neg real operators and not just OptionalOperators. R=bmeurer@chromium.org Committed: https://crrev.com/f68059b73aefd0b03ac3b04f8781d42ea4288237 Cr-Commit-Position: refs/heads/master@{#38383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ahaas
4 years, 4 months ago (2016-08-05 11:58:46 UTC) #1
Benedikt Meurer
Yeah, that would be awesome. LGTM.
4 years, 4 months ago (2016-08-05 12:19:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218023002/1
4 years, 4 months ago (2016-08-05 12:35:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 12:53:20 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 12:56:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f68059b73aefd0b03ac3b04f8781d42ea4288237
Cr-Commit-Position: refs/heads/master@{#38383}

Powered by Google App Engine
This is Rietveld 408576698