Ensure setEncodedSizeMemoryUsage() is called when |m_data| is cleared

Ensure setEncodedSizeMemoryUsage() is called when |m_data| is cleared

This CL
- Moves setEncodedSizeMemoryUsage(0) calls from the call sites of clearData()
  into the body of clearData(), which doesn't affect the behavior, and
- Replaces |m_data.clear()| in Resource.cpp with clearData(), so that
  the encodedSizeMemoryUsage is updated.

BUG=643135
Committed: https://crrev.com/82c4a08a0b9d5c3edf826c3cd1b16e2318dcc36b
Cr-Commit-Position: refs/heads/master@{#430919}

[hiroshige, 2016-09-01 10:57:13]

Description was changed from

==========
Call setEncodedSize() in Resource::clearData()

BUG=
==========

to

==========
Call setEncodedSize() in Resource::clearData()

BUG=643135
==========

[hiroshige, 2016-11-07 07:29:23]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 07:29:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 08:34:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 08:34:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hiroshige, 2016-11-07 09:21:13]

Description was changed from

==========
Call setEncodedSize() in Resource::clearData()

BUG=643135
==========

to

==========
Ensure setEncodedSizeMemoryUsage() is called when |m_data| is cleared

This CL
- Moves setEncodedSizeMemoryUsage(0) calls from the call sites of clearData()
  into the body of clearData(), which doesn't affect the behavior, and
- Replaces |m_data.clear()| in Resource.cpp with clearData(), such that
  the encodedSizeMemoryUsage is updated.

BUG=643135
==========

[hiroshige, 2016-11-07 09:22:30]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 09:22:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-07 09:22:50]

hiroshige@chromium.org changed reviewers:
+ hajimehoshi@chromium.org, yhirano@chromium.org

[hiroshige, 2016-11-07 09:22:50]

PTAL.

[commit-bot: I haz the power, 2016-11-07 10:43:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 10:44:00]

Dry run: This issue passed the CQ dry run.

[hajimehoshi, 2016-11-07 11:03:42]

lgtm

[yhirano, 2016-11-08 01:59:41]

LGTM

description: s/such that/so that/, I guess?

https://codereview.chromium.org/2218013002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/Resource.h (right):

https://codereview.chromium.org/2218013002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/Resource.h:402: void
setEncodedSizeMemoryUsage(size_t);
[optional] do we need this function?

[hiroshige, 2016-11-09 07:32:53]

Description was changed from

==========
Ensure setEncodedSizeMemoryUsage() is called when |m_data| is cleared

This CL
- Moves setEncodedSizeMemoryUsage(0) calls from the call sites of clearData()
  into the body of clearData(), which doesn't affect the behavior, and
- Replaces |m_data.clear()| in Resource.cpp with clearData(), such that
  the encodedSizeMemoryUsage is updated.

BUG=643135
==========

to

==========
Ensure setEncodedSizeMemoryUsage() is called when |m_data| is cleared

This CL
- Moves setEncodedSizeMemoryUsage(0) calls from the call sites of clearData()
  into the body of clearData(), which doesn't affect the behavior, and
- Replaces |m_data.clear()| in Resource.cpp with clearData(), so that
  the encodedSizeMemoryUsage is updated.

BUG=643135
==========

[hiroshige, 2016-11-09 07:33:43]

> description: s/such that/so that/, I guess?
Thanks, fixed.

https://codereview.chromium.org/2218013002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/Resource.h (right):

https://codereview.chromium.org/2218013002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/Resource.h:402: void
setEncodedSizeMemoryUsage(size_t);
On 2016/11/08 01:59:41, yhirano wrote:
> [optional] do we need this function?

Removed.

[hiroshige, 2016-11-09 07:33:50]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-11-09 07:33:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
hajimehoshi@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2218013002/#ps100001
(title: "Remove setEncodedSizeMemoryUsage()")

[commit-bot: I haz the power, 2016-11-09 07:34:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 11:42:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 11:42:13]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hiroshige, 2016-11-09 11:43:46]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-11-09 11:43:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 13:24:51]

Description was changed from

==========
Ensure setEncodedSizeMemoryUsage() is called when |m_data| is cleared

This CL
- Moves setEncodedSizeMemoryUsage(0) calls from the call sites of clearData()
  into the body of clearData(), which doesn't affect the behavior, and
- Replaces |m_data.clear()| in Resource.cpp with clearData(), so that
  the encodedSizeMemoryUsage is updated.

BUG=643135
==========

to

==========
Ensure setEncodedSizeMemoryUsage() is called when |m_data| is cleared

This CL
- Moves setEncodedSizeMemoryUsage(0) calls from the call sites of clearData()
  into the body of clearData(), which doesn't affect the behavior, and
- Replaces |m_data.clear()| in Resource.cpp with clearData(), so that
  the encodedSizeMemoryUsage is updated.

BUG=643135
==========

[commit-bot: I haz the power, 2016-11-09 13:24:52]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-09 13:33:01]

Description was changed from

==========
Ensure setEncodedSizeMemoryUsage() is called when |m_data| is cleared

This CL
- Moves setEncodedSizeMemoryUsage(0) calls from the call sites of clearData()
  into the body of clearData(), which doesn't affect the behavior, and
- Replaces |m_data.clear()| in Resource.cpp with clearData(), so that
  the encodedSizeMemoryUsage is updated.

BUG=643135
==========

to

==========
Ensure setEncodedSizeMemoryUsage() is called when |m_data| is cleared

This CL
- Moves setEncodedSizeMemoryUsage(0) calls from the call sites of clearData()
  into the body of clearData(), which doesn't affect the behavior, and
- Replaces |m_data.clear()| in Resource.cpp with clearData(), so that
  the encodedSizeMemoryUsage is updated.

BUG=643135

Committed: https://crrev.com/82c4a08a0b9d5c3edf826c3cd1b16e2318dcc36b
Cr-Commit-Position: refs/heads/master@{#430919}
==========

[commit-bot: I haz the power, 2016-11-09 13:33:02]

Patchset 6 (id:??) landed as
https://crrev.com/82c4a08a0b9d5c3edf826c3cd1b16e2318dcc36b
Cr-Commit-Position: refs/heads/master@{#430919}