Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2218003003: Fix integer overflow in FrameView::m_visuallyNonEmptyPixelCount (Closed)

Created:
4 years, 4 months ago by hiroshige
Modified:
4 years, 4 months ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix integer overflow in FrameView::m_visuallyNonEmptyPixelCount BUG=634819 Committed: https://crrev.com/18614431f3b09bf247aaaece45839a1739affc01 Cr-Commit-Position: refs/heads/master@{#410380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
hiroshige
bokan@, could you take a look as a core/frame OWNER?
4 years, 4 months ago (2016-08-05 14:22:59 UTC) #2
bokan
Sorry for the delay. lgtm.
4 years, 4 months ago (2016-08-08 15:27:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218003003/1
4 years, 4 months ago (2016-08-08 15:30:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 16:37:02 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/18614431f3b09bf247aaaece45839a1739affc01 Cr-Commit-Position: refs/heads/master@{#410380}
4 years, 4 months ago (2016-08-08 16:39:20 UTC) #8
esprehn
Please add a test for this or revert it. :)
4 years, 4 months ago (2016-08-08 20:01:51 UTC) #9
bokan
My bad, should have thought to ask for one.
4 years, 4 months ago (2016-08-08 20:03:13 UTC) #10
hiroshige
4 years, 4 months ago (2016-08-09 08:57:44 UTC) #11
Message was sent while issue was closed.
On 2016/08/08 20:03:13, bokan wrote:
> My bad, should have thought to ask for one.

Added an unit test: https://codereview.chromium.org/2229753002/.

Powered by Google App Engine
This is Rietveld 408576698