Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 22180002: Move some mock files out of webkit_support target as they're no longer used there (Closed)

Created:
7 years, 4 months ago by kinuko
Modified:
7 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move some mock files out of webkit_support target as they're no longer used there (They should be eventually moved into content/public/test rather than duplicated in two gypi files) BUG=265769 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215872

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 1 chunk +7 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 2 chunks +6 lines, -0 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kinuko
gypi entries change only. jochen: maybe you can review?
7 years, 4 months ago (2013-08-06 07:57:17 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 4 months ago (2013-08-06 08:03:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/22180002/36001
7 years, 4 months ago (2013-08-06 08:54:24 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=183902
7 years, 4 months ago (2013-08-06 10:37:50 UTC) #4
kinuko
7 years, 4 months ago (2013-08-06 11:27:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r215872 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698