Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2217983003: Subzero: Use the memset inline threshold for memset. (Closed)

Created:
4 years, 4 months ago by Jim Stichnoth
Modified:
4 years, 4 months ago
Reviewers:
Eric Holk, Karl, John, manasijm
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Use the memset inline threshold for memset. Memset lowering was using the memcpy inline threshold instead of the memset threshold. Using the memset threshold as specified (16) seems to make spec2k performance slightly worse, so change it to the original value (8). BUG= none R=eholk@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=35e160025c5a7005f97c5ad55120999cf83a4ce1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/IceTargetLoweringX8632Traits.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceTargetLoweringX8664Traits.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 4 months ago (2016-08-05 14:28:56 UTC) #3
Eric Holk
lgtm
4 years, 4 months ago (2016-08-05 17:01:48 UTC) #4
Jim Stichnoth
4 years, 4 months ago (2016-08-05 21:11:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
35e160025c5a7005f97c5ad55120999cf83a4ce1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698