Merge all of the consumeNumber() logic and make a single call to getDouble.

Merge all of the consumeNumber() logic and make a single call to getDouble.

We don't need to do all of the math manually to convert the string into a number
value, we can just validate the input and then call getDouble. This is still
slower than the fast path which optimistically attempts to parse the whole input
as a double followed by a length, but it makes the code simpler which is nice. It
also means we now call charactersToDouble the same number of times in the fast
and slow paths.

I also converted CSSTokenizerInputStream::skipWhilePredicate to branch once
on is8Bit so we're not checking every time inside the loop.

BUG=605792
Committed: https://crrev.com/37f87f519d4f1e6d43286e1e433b81e217d3b467
Cr-Commit-Position: refs/heads/master@{#410588}

[esprehn, 2016-08-08 22:43:07]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 22:43:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-08-08 22:48:27]

Description was changed from

==========
Hacky hack.

BUG=
==========

to

==========
Merge all of the consumeNumber() logic and make a single call to getDouble.

We don't need to do all of the math manually to convert the string into a number
value, we can just validate the input and then call getDouble. This is still
slower than the fast path which optimistically attempts to parse the whole input
as a double followed by a length, but it makes the code simpler which is nice.
It
also means we now call charactersToDouble the same number of times in the fast
and slow paths.

I also converted CSSTokenizerInputStream::skipWhilePredicate to branch once
on is8Bit so we're not checking every time inside the loop.

BUG=605792
==========

[commit-bot: I haz the power, 2016-08-08 23:03:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 23:03:51]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[esprehn, 2016-08-09 02:19:05]

esprehn@chromium.org changed reviewers:
+ meade@chromium.org, timloh@chromium.org

[Timothy Loh, 2016-08-09 02:31:45]

yesssss lgtm!!

https://codereview.chromium.org/2217853002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp (right):

https://codereview.chromium.org/2217853002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp:406: double value =
m_input.getDouble(0, numberLength);
getDouble doesn't really need the start argument any more since it looks like
this is the only caller now

[esprehn, 2016-08-09 04:03:33]

https://codereview.chromium.org/2217853002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp (right):

https://codereview.chromium.org/2217853002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp:406: double value =
m_input.getDouble(0, numberLength);
On 2016/08/09 at 02:31:44, Timothy Loh wrote:
> getDouble doesn't really need the start argument any more since it looks like
this is the only caller now

Yeah, I'll do that next.

[esprehn, 2016-08-09 04:03:50]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-08-09 04:04:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meade_UTC10, 2016-08-09 04:21:58]

lgtm

[commit-bot: I haz the power, 2016-08-09 05:36:18]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-09 05:38:28]

Description was changed from

==========
Merge all of the consumeNumber() logic and make a single call to getDouble.

We don't need to do all of the math manually to convert the string into a number
value, we can just validate the input and then call getDouble. This is still
slower than the fast path which optimistically attempts to parse the whole input
as a double followed by a length, but it makes the code simpler which is nice.
It
also means we now call charactersToDouble the same number of times in the fast
and slow paths.

I also converted CSSTokenizerInputStream::skipWhilePredicate to branch once
on is8Bit so we're not checking every time inside the loop.

BUG=605792
==========

to

==========
Merge all of the consumeNumber() logic and make a single call to getDouble.

We don't need to do all of the math manually to convert the string into a number
value, we can just validate the input and then call getDouble. This is still
slower than the fast path which optimistically attempts to parse the whole input
as a double followed by a length, but it makes the code simpler which is nice.
It
also means we now call charactersToDouble the same number of times in the fast
and slow paths.

I also converted CSSTokenizerInputStream::skipWhilePredicate to branch once
on is8Bit so we're not checking every time inside the loop.

BUG=605792

Committed: https://crrev.com/37f87f519d4f1e6d43286e1e433b81e217d3b467
Cr-Commit-Position: refs/heads/master@{#410588}
==========

[commit-bot: I haz the power, 2016-08-09 05:38:29]

Patchset 5 (id:??) landed as
https://crrev.com/37f87f519d4f1e6d43286e1e433b81e217d3b467
Cr-Commit-Position: refs/heads/master@{#410588}