Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2217833004: Reland of Don't IAT patch SetUnhandledExceptionFilter when ASan is active (Closed)

Created:
4 years, 4 months ago by inferno
Modified:
4 years, 4 months ago
CC:
chromium-reviews, pennymac+watch_chromium.org, caitkp+watch_chromium.org, penny
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Don't IAT patch SetUnhandledExceptionFilter when ASan is active (patchset #1 id:1 of https://codereview.chromium.org/2225453002/ ) Reason for revert: This patch didn't impact Crashpad. Original issue's description: > Revert of Don't IAT patch SetUnhandledExceptionFilter when ASan is active (patchset #1 id:1 of https://codereview.chromium.org/2220583002/ ) > > Reason for revert: > This causes crashpad to emit "haven't called UseHandler()" errors later. > > Original issue's description: > > Don't IAT patch SetUnhandledExceptionFilter when ASan is active > > > > ASan installs its own exception filter that ClusterFuzz needs to see. > > > > R=robertshield@chromium.org,inferno@chromium.org > > BUG=626373 > > > > Committed: https://crrev.com/3894e46c8c2702e12d2ddec12f186d7c1cf5c412 > > Cr-Commit-Position: refs/heads/master@{#410077} > > TBR=inferno@chromium.org,robertshield@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=626373 > > Committed: https://crrev.com/07928da2532a9a7d1149d0878d0931dd209f0d3c > Cr-Commit-Position: refs/heads/master@{#410106} TBR=robertshield@chromium.org,scottmg@chromium.org,rsesek@chromium.org,aarya@google.com,rnk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=626373 Committed: https://crrev.com/009fe04704c6cd15b521ce44026331fa1bd37f11 Cr-Commit-Position: refs/heads/master@{#410232}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome_elf/chrome_elf_main.cc View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
inferno
Created Reland of Don't IAT patch SetUnhandledExceptionFilter when ASan is active
4 years, 4 months ago (2016-08-06 00:45:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217833004/1
4 years, 4 months ago (2016-08-06 00:46:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-06 00:47:03 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-06 00:48:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/009fe04704c6cd15b521ce44026331fa1bd37f11
Cr-Commit-Position: refs/heads/master@{#410232}

Powered by Google App Engine
This is Rietveld 408576698