third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js - Issue 2217783002: DevTools: use view locations in the elements and sources sidebars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

Issue 2217783002: DevTools: use view locations in the elements and sources sidebars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ready for review Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js ('K') | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js » ('j') | third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

index 45ce5c37f71a8298cd7063c9cb212ea42cbf8cf5..05ca0e085e5bc10aec8c5a2834898fe4da069bdc 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

@@ -72,9 +72,9 @@ WebInspector.RequestPreviewView.prototype = {

{

this._previewView = view;

view.show(this.element);

- if (view instanceof WebInspector.View) {

+ if (view instanceof WebInspector.SimpleView) {

var toolbar = new WebInspector.Toolbar("network-item-preview-toolbar", this.element);

- for (var item of /** @type {!WebInspector.View} */ (view).toolbarItems())

+ for (var item of /** @type {!WebInspector.View} */ (this._previewView).syncToolbarItems())

dgozman 2016/08/06 00:56:10 Cast to SimpleView.

toolbar.appendToolbarItem(item);

}

this._previewViewHandledForTest(view);