Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2217783002: DevTools: use view locations in the elements and sources sidebars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
index 60596075a7e33af05d53569a4ad44adb41ae6da1..f09cb740c3d6a6eacbb8221703e92d2715963068 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
@@ -139,7 +139,8 @@ WebInspector.SourcesPanel.prototype = {
if (hasThreads && !this.sidebarPanes.threads) {
this.sidebarPanes.threads = new WebInspector.ThreadsSidebarPane();
if (this._sidebarPaneStack) {
- this._sidebarPaneStack.insertViewBefore(this.sidebarPanes.threads, this._splitWidget.isVertical() ? this.sidebarPanes.watchExpressions : this.sidebarPanes.callstack, true);
+ this._sidebarPaneStack.showView(this.sidebarPanes.threads);
+ // this._splitWidget.isVertical() ? this.sidebarPanes.watchExpressions : this.sidebarPanes.callstack, true);
dgozman 2016/08/05 01:32:09 Commented code.
}
}
},
@@ -1125,8 +1126,8 @@ WebInspector.SourcesPanel.prototype = {
var vbox = new WebInspector.VBox();
vbox.element.appendChild(this._debugToolbarDrawer);
vbox.setMinimumAndPreferredSizes(25, 25, WebInspector.SourcesPanel.minToolbarWidth, 100);
- this._sidebarPaneStack = new WebInspector.View.ExpandableStackContainer();
- this._sidebarPaneStack.show(vbox.element);
+ this._sidebarPaneStack = WebInspector.viewManager.createStackLocation("sources-sidebar");
+ this._sidebarPaneStack.widget().show(vbox.element);
vbox.element.appendChild(this._debugToolbar.element);
if (!vertically) {
@@ -1154,15 +1155,15 @@ WebInspector.SourcesPanel.prototype = {
this._sidebarPaneStack.appendView(this.sidebarPanes.eventListenerBreakpoints);
this._sidebarPaneStack.appendView(this.sidebarPanes.objectEventListeners);
- var tabbedPane = new WebInspector.View.TabbedPaneContainer();
- splitWidget.setSidebarWidget(tabbedPane);
- tabbedPane.appendView(this.sidebarPanes.scopechain);
- tabbedPane.appendView(this.sidebarPanes.watchExpressions);
+ var tabbedLocation = WebInspector.viewManager.createTabbedLocation("sources-sidebar-tabs");
+ splitWidget.setSidebarWidget(tabbedLocation.tabbedPane());
+ tabbedLocation.appendView(this.sidebarPanes.scopechain);
+ tabbedLocation.appendView(this.sidebarPanes.watchExpressions);
if (this.sidebarPanes.serviceWorkers)
- tabbedPane.appendView(this.sidebarPanes.serviceWorkers);
- tabbedPane.selectTab(this._lastSelectedTabSetting.get());
- tabbedPane.addEventListener(WebInspector.TabbedPane.EventTypes.TabSelected, this._tabSelected, this);
- this._extensionSidebarPanesContainer = tabbedPane;
+ tabbedLocation.appendView(this.sidebarPanes.serviceWorkers);
+ // tabbedLocation.show(this._lastSelectedTabSetting.get());
dgozman 2016/08/05 01:32:09 Commented code.
+ tabbedLocation.tabbedPane().addEventListener(WebInspector.TabbedPane.EventTypes.TabSelected, this._tabSelected, this);
+ this._extensionSidebarPanesContainer = tabbedLocation;
this.sidebarPaneView = splitWidget;
}

Powered by Google App Engine
This is Rietveld 408576698