Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js

Issue 2217783002: DevTools: use view locations in the elements and sources sidebars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 /** 26 /**
27 * @constructor 27 * @constructor
28 * @extends {WebInspector.View} 28 * @extends {WebInspector.SimpleView}
29 */ 29 */
30 WebInspector.CallStackSidebarPane = function() 30 WebInspector.CallStackSidebarPane = function()
31 { 31 {
32 WebInspector.View.call(this, WebInspector.UIString("Call Stack")); 32 WebInspector.SimpleView.call(this, WebInspector.UIString("Call Stack"));
33 this.element.addEventListener("keydown", this._keyDown.bind(this), true); 33 this.element.addEventListener("keydown", this._keyDown.bind(this), true);
34 this.element.tabIndex = 0; 34 this.element.tabIndex = 0;
35 this.callFrameList = new WebInspector.UIList(); 35 this.callFrameList = new WebInspector.UIList();
36 this.callFrameList.show(this.element); 36 this.callFrameList.show(this.element);
37 this._linkifier = new WebInspector.Linkifier(); 37 this._linkifier = new WebInspector.Linkifier();
38 WebInspector.moduleSetting("enableAsyncStackTraces").addChangeListener(this. _asyncStackTracesStateChanged, this); 38 WebInspector.moduleSetting("enableAsyncStackTraces").addChangeListener(this. _asyncStackTracesStateChanged, this);
39 WebInspector.moduleSetting("skipStackFramesPattern").addChangeListener(this. _blackboxingStateChanged, this); 39 WebInspector.moduleSetting("skipStackFramesPattern").addChangeListener(this. _blackboxingStateChanged, this);
40 /** @type {!Array<!WebInspector.CallStackSidebarPane.CallFrame>} */ 40 /** @type {!Array<!WebInspector.CallStackSidebarPane.CallFrame>} */
41 this.callFrames = []; 41 this.callFrames = [];
42 this._locationPool = new WebInspector.LiveLocationPool(); 42 this._locationPool = new WebInspector.LiveLocationPool();
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
419 }, 419 },
420 420
421 _keyDown: function(event) 421 _keyDown: function(event)
422 { 422 {
423 if (event.altKey || event.shiftKey || event.metaKey || event.ctrlKey) 423 if (event.altKey || event.shiftKey || event.metaKey || event.ctrlKey)
424 return; 424 return;
425 if (event.key === "ArrowUp" && this._selectPreviousCallFrameOnStack() || event.key === "ArrowDown" && this._selectNextCallFrameOnStack()) 425 if (event.key === "ArrowUp" && this._selectPreviousCallFrameOnStack() || event.key === "ArrowDown" && this._selectNextCallFrameOnStack())
426 event.consume(true); 426 event.consume(true);
427 }, 427 },
428 428
429 __proto__: WebInspector.View.prototype 429 __proto__: WebInspector.SimpleView.prototype
430 } 430 }
431 431
432 /** 432 /**
433 * @constructor 433 * @constructor
434 * @extends {WebInspector.UIList.Item} 434 * @extends {WebInspector.UIList.Item}
435 * @param {string} functionName 435 * @param {string} functionName
436 * @param {!WebInspector.DebuggerModel.Location} location 436 * @param {!WebInspector.DebuggerModel.Location} location
437 * @param {!WebInspector.Linkifier} linkifier 437 * @param {!WebInspector.Linkifier} linkifier
438 * @param {?WebInspector.DebuggerModel.CallFrame} debuggerCallFrame 438 * @param {?WebInspector.DebuggerModel.CallFrame} debuggerCallFrame
439 * @param {!WebInspector.LiveLocationPool} locationPool 439 * @param {!WebInspector.LiveLocationPool} locationPool
(...skipping 25 matching lines...) Expand all
465 var uiLocation = liveLocation.uiLocation(); 465 var uiLocation = liveLocation.uiLocation();
466 if (!uiLocation) 466 if (!uiLocation)
467 return; 467 return;
468 var text = uiLocation.linkText(); 468 var text = uiLocation.linkText();
469 this.setSubtitle(text.trimMiddle(30)); 469 this.setSubtitle(text.trimMiddle(30));
470 this.subtitleElement.title = text; 470 this.subtitleElement.title = text;
471 }, 471 },
472 472
473 __proto__: WebInspector.UIList.Item.prototype 473 __proto__: WebInspector.UIList.Item.prototype
474 } 474 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698