Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

Issue 2217783002: DevTools: use view locations in the elements and sources sidebars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 this._previewView.show(this.element); 65 this._previewView.show(this.element);
66 66
67 /** 67 /**
68 * @param {!WebInspector.Widget} view 68 * @param {!WebInspector.Widget} view
69 * @this {WebInspector.RequestPreviewView} 69 * @this {WebInspector.RequestPreviewView}
70 */ 70 */
71 function handlePreviewView(view) 71 function handlePreviewView(view)
72 { 72 {
73 this._previewView = view; 73 this._previewView = view;
74 view.show(this.element); 74 view.show(this.element);
75 if (view instanceof WebInspector.View) { 75 if (view instanceof WebInspector.SimpleView) {
76 var toolbar = new WebInspector.Toolbar("network-item-preview-too lbar", this.element); 76 var toolbar = new WebInspector.Toolbar("network-item-preview-too lbar", this.element);
77 for (var item of /** @type {!WebInspector.View} */ (view).toolba rItems()) 77 for (var item of /** @type {!WebInspector.SimpleView} */ (this._ previewView).syncToolbarItems())
78 toolbar.appendToolbarItem(item); 78 toolbar.appendToolbarItem(item);
79 } 79 }
80 this._previewViewHandledForTest(view); 80 this._previewViewHandledForTest(view);
81 } 81 }
82 }, 82 },
83 83
84 /** 84 /**
85 * @param {!WebInspector.Widget} view 85 * @param {!WebInspector.Widget} view
86 */ 86 */
87 _previewViewHandledForTest: function(view) { }, 87 _previewViewHandledForTest: function(view) { },
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 190
191 if (this.request.resourceType() === WebInspector.resourceTypes.Other ) 191 if (this.request.resourceType() === WebInspector.resourceTypes.Other )
192 return this._createEmptyWidget(); 192 return this._createEmptyWidget();
193 193
194 return WebInspector.RequestView.nonSourceViewForRequest(this.request ); 194 return WebInspector.RequestView.nonSourceViewForRequest(this.request );
195 } 195 }
196 }, 196 },
197 197
198 __proto__: WebInspector.RequestContentView.prototype 198 __proto__: WebInspector.RequestContentView.prototype
199 } 199 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698