Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js

Issue 2217783002: DevTools: use view locations in the elements and sources sidebars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 var resultTreeElement = new WebInspector.AuditResultSidebarTreeElement(t his, results, mainResourceURL, ordinal); 122 var resultTreeElement = new WebInspector.AuditResultSidebarTreeElement(t his, results, mainResourceURL, ordinal);
123 this.auditResultsTreeElement.appendChild(resultTreeElement); 123 this.auditResultsTreeElement.appendChild(resultTreeElement);
124 resultTreeElement.revealAndSelect(); 124 resultTreeElement.revealAndSelect();
125 }, 125 },
126 126
127 /** 127 /**
128 * @param {!Array.<!WebInspector.AuditCategoryResult>} categoryResults 128 * @param {!Array.<!WebInspector.AuditCategoryResult>} categoryResults
129 */ 129 */
130 showResults: function(categoryResults) 130 showResults: function(categoryResults)
131 { 131 {
132 if (!categoryResults._resultView) { 132 if (!categoryResults._resultLocation) {
133 categoryResults.sort((a, b) => (a.title || "").localeCompare(b.title || "")); 133 categoryResults.sort((a, b) => (a.title || "").localeCompare(b.title || ""));
134 var resultView = new WebInspector.View.ExpandableStackContainer(); 134 var resultView = WebInspector.viewManager.createStackLocation();
135 for (var i = 0; i < categoryResults.length; ++i) 135 for (var i = 0; i < categoryResults.length; ++i)
136 resultView.appendView(new WebInspector.AuditCategoryResultPane(c ategoryResults[i]), true); 136 resultView.showView(new WebInspector.AuditCategoryResultPane(cat egoryResults[i]));
137 categoryResults._resultView = resultView; 137 categoryResults._resultLocation = resultView;
138 } 138 }
139 this.visibleView = categoryResults._resultView; 139 this.visibleView = categoryResults._resultLocation.widget();
140 }, 140 },
141 141
142 showLauncherView: function() 142 showLauncherView: function()
143 { 143 {
144 this.visibleView = this._launcherView; 144 this.visibleView = this._launcherView;
145 }, 145 },
146 146
147 get visibleView() 147 get visibleView()
148 { 148 {
149 return this._visibleView; 149 return this._visibleView;
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
554 } 554 }
555 555
556 // Contributed audit rules should go into this namespace. 556 // Contributed audit rules should go into this namespace.
557 WebInspector.AuditRules = {}; 557 WebInspector.AuditRules = {};
558 558
559 /** 559 /**
560 * Contributed audit categories should go into this namespace. 560 * Contributed audit categories should go into this namespace.
561 * @type {!Object.<string, function(new:WebInspector.AuditCategory)>} 561 * @type {!Object.<string, function(new:WebInspector.AuditCategory)>}
562 */ 562 */
563 WebInspector.AuditCategories = {}; 563 WebInspector.AuditCategories = {};
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698