Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

Issue 2217783002: DevTools: use view locations in the elements and sources sidebars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 { 81 {
82 WebInspector.SettingsScreen._showSettingsScreen(); 82 WebInspector.SettingsScreen._showSettingsScreen();
83 return this._tabbedLocation; 83 return this._tabbedLocation;
84 }, 84 },
85 85
86 /** 86 /**
87 * @param {string} name 87 * @param {string} name
88 */ 88 */
89 selectTab: function(name) 89 selectTab: function(name)
90 { 90 {
91 this._tabbedLocation.showView(name); 91 WebInspector.viewManager.showView(name);
dgozman 2016/08/05 01:32:09 I'm worried we will have name clashes soon.
92 }, 92 },
93 93
94 /** 94 /**
95 * @param {!Event} event 95 * @param {!Event} event
96 */ 96 */
97 _keyDown: function(event) 97 _keyDown: function(event)
98 { 98 {
99 var shiftKeyCode = 16; 99 var shiftKeyCode = 16;
100 if (event.keyCode === shiftKeyCode && ++this._developerModeCounter > 5) 100 if (event.keyCode === shiftKeyCode && ++this._developerModeCounter > 5)
101 this.contentElement.classList.add("settings-developer-mode"); 101 this.contentElement.classList.add("settings-developer-mode");
(...skipping 469 matching lines...) Expand 10 before | Expand all | Expand 10 after
571 return; 571 return;
572 var settings = extension.descriptor()["settings"]; 572 var settings = extension.descriptor()["settings"];
573 if (settings && settings.indexOf(setting.name) !== -1) { 573 if (settings && settings.indexOf(setting.name) !== -1) {
574 InspectorFrontendHost.bringToFront(); 574 InspectorFrontendHost.bringToFront();
575 WebInspector.SettingsScreen._showSettingsScreen(extension.descri ptor()["id"]); 575 WebInspector.SettingsScreen._showSettingsScreen(extension.descri ptor()["id"]);
576 success = true; 576 success = true;
577 } 577 }
578 } 578 }
579 } 579 }
580 } 580 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698