DevTools: use view locations in the elements and sources sidebars.

third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 797 matching lines @@
         view.focus();
 
         this.visibleView = view;
 
         var profileTypeSection = this._typeIdToSidebarSection[profile.profileType().id];
         var sidebarElement = profileTypeSection.sidebarElementForProfile(profile);
         sidebarElement.revealAndSelect();
 
         this._profileViewToolbar.removeToolbarItems();
 
-        var toolbarItems = view.toolbarItems();
+        var toolbarItems = view.syncToolbarItems();
         for (var i = 0; i < toolbarItems.length; ++i)
             this._profileViewToolbar.appendToolbarItem(toolbarItems[i]);

[dgozman, 2016/08/05 01:32:09]

Let's follow up with an OverlayViewLocation with a toolbar at the top (like
profiles do).

 
         return view;
     },
 
     /**
      * @override
      * @param {!HeapProfilerAgent.HeapSnapshotObjectId} snapshotObjectId
      * @param {string} perspectiveName
      */
     showObject: function(snapshotObjectId, perspectiveName)
@@ skipping 455 matching lines @@
      * @return {boolean}
      */
     handleAction: function(context, actionId)
     {
         var panel = WebInspector.context.flavor(WebInspector.ProfilesPanel);
         console.assert(panel && panel instanceof WebInspector.ProfilesPanel);
         panel.toggleRecord();
         return true;
     }
 }