Reset most ICs by returning to the canonical empty data arrays.

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 1835 matching lines @@
   }
 
   intptr_t NumArgsTested() const;
 
   intptr_t deopt_id() const {
     return raw_ptr()->deopt_id_;
   }
 
   bool IsImmutable() const;
 
-  void Reset() const;
-  void ResetData() const;
+  void Reset(Zone* zone) const;
 
   // Note: only deopts with reasons before Unknown in this list are recorded in
   // the ICData. All other reasons are used purely for informational messages
   // printed during deoptimization itself.
   #define DEOPT_REASONS(V)                                                     \
     V(BinarySmiOp)                                                             \
     V(BinaryMintOp)                                                            \
     V(DoubleToSmi)                                                             \
     V(CheckSmi)                                                                \
     V(Unknown)                                                                 \
@@ skipping 85 matching lines @@
 
   // Clear all entries with the sentinel value and reset the first entry
   // with the dummy target entry.
   void ClearAndSetStaticTarget(const Function& func) const;
 
   // Returns the first index that should be used to for a new entry. Will
   // grow the array if necessary.
   RawArray* FindFreeIndex(intptr_t* index) const;
 
   void DebugDump() const;
-  void ValidateSentinelLocations() const;
 
   // Returns true if this is a two arg smi operation.
   bool AddSmiSmiCheckForFastSmiStubs() const;
 
   // Used for unoptimized static calls when no class-ids are checked.
   void AddTarget(const Function& target) const;
 
   // Adding checks.
 
   // Adds one more class test to ICData. Length of 'classes' must be equal to
@@ skipping 152 matching lines @@
                                         bool,
                                         ICData::kStaticCallPos,
                                         ICData::kStaticCallSize> {};
 #if defined(DEBUG)
   // Used in asserts to verify that a check is not added twice.
   bool HasCheck(const GrowableArray<intptr_t>& cids) const;
 #endif  // DEBUG
 
   intptr_t TestEntryLength() const;
   static RawArray* NewNonCachedEmptyICDataArray(intptr_t num_args_tested);
-  static RawArray* NewEmptyICDataArray(intptr_t num_args_tested);
+  static RawArray* CachedEmptyICDataArray(intptr_t num_args_tested);
   static RawICData* NewDescriptor(Zone* zone,
                                   const Function& owner,
                                   const String& target_name,
                                   const Array& arguments_descriptor,
                                   intptr_t deopt_id,
                                   intptr_t num_args_tested,
                                   bool is_static_call);
 
   static void WriteSentinel(const Array& data, intptr_t test_entry_length);
 
@@ skipping 2350 matching lines @@
     return raw_ptr()->code_source_map_;
   }
 
   void set_code_source_map(const CodeSourceMap& code_source_map) const {
     ASSERT(code_source_map.IsOld());
     StorePointer(&raw_ptr()->code_source_map_, code_source_map.raw());
   }
 
   // Used during reloading (see object_reload.cc). Calls Reset on all ICDatas
   // that are embedded inside the Code object.
-  void ResetICDatas() const;
+  void ResetICDatas(Zone* zone) const;
 
   TokenPosition GetTokenPositionAt(intptr_t offset) const;
 
   // Array of DeoptInfo objects.
   RawArray* deopt_info_array() const {
     return raw_ptr()->deopt_info_array_;
   }
   void set_deopt_info_array(const Array& array) const;
 
   RawArray* stackmaps() const {
@@ skipping 4218 matching lines @@
 
 inline void TypeArguments::SetHash(intptr_t value) const {
   // This is only safe because we create a new Smi, which does not cause
   // heap allocation.
   StoreSmi(&raw_ptr()->hash_, Smi::New(value));
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_