Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 221773002: drive: Deprecate FakeDriveService::LoadAccountMetadataForWapi (Closed)

Created:
6 years, 8 months ago by hashimoto
Modified:
6 years, 8 months ago
Reviewers:
kinaba, tzik
CC:
chromium-reviews, kinuko+watch, nhiroki, tzik
Visibility:
Public.

Description

drive: Deprecate FakeDriveService::LoadAccountMetadataForWapi Mark the method as deprecated. Set account metadata values in ctor. BUG=334544 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261355

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/drive/fake_drive_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend_v1/api_util_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
hashimoto
6 years, 8 months ago (2014-04-02 04:14:21 UTC) #1
kinaba
lgtm
6 years, 8 months ago (2014-04-02 04:20:37 UTC) #2
tzik
lgtm
6 years, 8 months ago (2014-04-02 05:16:52 UTC) #3
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 8 months ago (2014-04-02 06:28:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/221773002/1
6 years, 8 months ago (2014-04-02 06:28:21 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 12:15:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-02 12:15:51 UTC) #7
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 8 months ago (2014-04-02 13:10:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/221773002/1
6 years, 8 months ago (2014-04-02 13:10:55 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 17:49:12 UTC) #10
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=60417
6 years, 8 months ago (2014-04-02 17:49:14 UTC) #11
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 8 months ago (2014-04-03 02:16:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/221773002/1
6 years, 8 months ago (2014-04-03 02:23:11 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 04:21:33 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=293066
6 years, 8 months ago (2014-04-03 04:21:34 UTC) #15
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 8 months ago (2014-04-03 04:22:14 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/221773002/1
6 years, 8 months ago (2014-04-03 04:27:19 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 10:12:32 UTC) #18
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 10:12:33 UTC) #19
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 8 months ago (2014-04-03 10:12:57 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/221773002/1
6 years, 8 months ago (2014-04-03 10:15:40 UTC) #21
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 11:54:21 UTC) #22
Message was sent while issue was closed. 
Change committed as 261355

Powered by Google App Engine
This is Rietveld 408576698