Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1481)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 2217723004: Converted Observatory isolate-summary element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Removed patch file Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index afd924048b1a1113b1f0117d1d6e6b08f5a27408..bc21be8ca177a58e2db11295e96751e0c35d21cd 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -1077,7 +1077,7 @@ class TagProfile {
}
}
-class HeapSpace extends Observable {
+class HeapSpace extends Observable implements M.HeapSpace {
@observable int used = 0;
@observable int capacity = 0;
@observable int external = 0;
@@ -1139,7 +1139,7 @@ class Isolate extends ServiceObjectOwner implements M.Isolate {
return (new DateTime.now().difference(startTime));
}
- @observable ObservableMap counters = new ObservableMap();
+ @observable Map counters = {};
void _updateRunState() {
topFrame = (pauseEvent != null ? pauseEvent.topFrame : null);
@@ -1441,18 +1441,18 @@ class Isolate extends ServiceObjectOwner implements M.Isolate {
for (var i = 0; i < counts.length; i++) {
sum += counts[i];
}
- // TODO: Why does this not work without this?
- counters = toObservable({});
+ var _counters = {};
if (sum == 0) {
for (var i = 0; i < names.length; i++) {
- counters[names[i]] = '0.0%';
+ _counters[names[i]] = '0.0%';
}
} else {
for (var i = 0; i < names.length; i++) {
- counters[names[i]] =
+ _counters[names[i]] =
(counts[i] / sum * 100.0).toStringAsFixed(2) + '%';
}
}
+ counters = _counters;
}
updateHeapsFromMap(map['_heaps']);
« no previous file with comments | « runtime/observatory/lib/src/models/objects/isolate.dart ('k') | runtime/observatory/observatory_sources.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698