Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2217723004: Converted Observatory isolate-summary element (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merging patch #

Patch Set 3 : Added final tests #

Total comments: 2

Patch Set 4 : Removed patch file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+571 lines, -268 lines) Patch
M pkg/pkg.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/elements.dart View 1 7 chunks +12 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/models.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 3 chunks +58 lines, -2 lines 0 comments Download
A runtime/observatory/lib/src/elements/isolate/counter_chart.dart View 1 chunk +77 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/isolate/shared_summary.dart View 1 2 1 chunk +155 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/isolate/shared_summary_wrapper.dart View 1 1 chunk +167 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_summary.dart View 2 chunks +0 lines, -88 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_summary.html View 1 chunk +0 lines, -142 lines 0 comments Download
M runtime/observatory/lib/src/elements/observatory_application.dart View 1 chunk +8 lines, -6 lines 0 comments Download
D runtime/observatory/lib/src/elements/observatory_application.html View 1 chunk +0 lines, -8 lines 0 comments Download
A + runtime/observatory/lib/src/models/objects/heap_space.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/isolate.dart View 1 chunk +46 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 3 chunks +4 lines, -1 line 0 comments Download
A + runtime/observatory/tests/observatory_ui/isolate/counter_chart/element_test.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/isolate/counter_chart/element_test.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/isolate/isolate-shared-summary/element_test.dart View 1 2 1 chunk +10 lines, -4 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/isolate/isolate-shared-summary/element_test.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/mocks/objects/heap_space.dart View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/isolate.dart View 1 2 1 chunk +11 lines, -1 line 0 comments Download
M runtime/observatory/web/index.html View 2 chunks +1 line, -1 line 0 comments Download
M runtime/observatory/web/main.dart View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
cbernaschina
4 years, 4 months ago (2016-08-06 00:46:44 UTC) #2
cbernaschina
4 years, 4 months ago (2016-08-09 19:11:38 UTC) #4
Cutch
LGTM after deleting the patch file https://codereview.chromium.org/2217723004/diff/40001/patch File patch (right): https://codereview.chromium.org/2217723004/diff/40001/patch#newcode2 patch:2: diff --git a/runtime/observatory/lib/src/elements/observatory_application.html ...
4 years, 4 months ago (2016-08-09 20:04:22 UTC) #6
cbernaschina
https://codereview.chromium.org/2217723004/diff/40001/patch File patch (right): https://codereview.chromium.org/2217723004/diff/40001/patch#newcode2 patch:2: diff --git a/runtime/observatory/lib/src/elements/observatory_application.html b/runtime/observatory/lib/src/elements/observatory_application.html On 2016/08/09 20:04:22, Cutch wrote: ...
4 years, 4 months ago (2016-08-09 20:06:47 UTC) #7
cbernaschina
4 years, 4 months ago (2016-08-09 20:15:30 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
a5443086a0b45e18d4d2c737b36988a689affdc2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698