Tracing V2: Field number constants for protobuf plugin.

Tracing V2: Field number constants for protobuf plugin.

Basic reflection with exposure of original proto field numbers
as constants in the generated stubs.

BUG=608721
Committed: https://crrev.com/437896040998aadd2c85c802a2d85d9b20adde6f
Cr-Commit-Position: refs/heads/master@{#410040}

[kraynov, 2016-08-04 20:50:44]

The CQ bit was checked by kraynov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 20:51:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kraynov, 2016-08-04 20:52:30]

kraynov@chromium.org changed reviewers:
+ alph@chromium.org, primiano@chromium.org

[kraynov, 2016-08-04 20:52:30]

PTAL

[kraynov, 2016-08-04 20:52:36]

The CQ bit was unchecked by kraynov@chromium.org

[Primiano Tucci (use gerrit), 2016-08-05 08:52:05]

Overall LG but I think you don't need most of this code an you can use just
field.camelcase_name().
See
https://cs.chromium.org/chromium/src/third_party/protobuf/src/google/protobuf...

https://codereview.chromium.org/2217703002/diff/1/components/tracing/test/exa...
File components/tracing/test/example_proto/test_messages.proto (right):

https://codereview.chromium.org/2217703002/diff/1/components/tracing/test/exa...
components/tracing/test/example_proto/test_messages.proto:90: // optional bool _
= 100;
not sure what is the value of this comment here?
I'd just rip out lines 88-90

https://codereview.chromium.org/2217703002/diff/1/components/tracing/tools/pr...
File components/tracing/tools/proto_zero_plugin/proto_zero_generator.cc (right):

https://codereview.chromium.org/2217703002/diff/1/components/tracing/tools/pr...
components/tracing/tools/proto_zero_plugin/proto_zero_generator.cc:52: return
CharCase::UPPER;
I think here you are reinventing cctype's isupper(), isalpha(), isdigit() etc.

https://codereview.chromium.org/2217703002/diff/1/components/tracing/tools/pr...
components/tracing/tools/proto_zero_plugin/proto_zero_generator.cc:561:
std::string name = NameToCamelCase(field->name());
can you not just use field->camelcase_name()

[kraynov, 2016-08-05 11:05:53]

Will check the camelcase_name()

https://codereview.chromium.org/2217703002/diff/1/components/tracing/tools/pr...
File components/tracing/tools/proto_zero_plugin/proto_zero_generator.cc (right):

https://codereview.chromium.org/2217703002/diff/1/components/tracing/tools/pr...
components/tracing/tools/proto_zero_plugin/proto_zero_generator.cc:52: return
CharCase::UPPER;
On 2016/08/05 08:52:05, Primiano Tucci wrote:
> I think here you are reinventing cctype's isupper(), isalpha(), isdigit() etc.

Acknowledged.

https://codereview.chromium.org/2217703002/diff/1/components/tracing/tools/pr...
components/tracing/tools/proto_zero_plugin/proto_zero_generator.cc:561:
std::string name = NameToCamelCase(field->name());
On 2016/08/05 08:52:05, Primiano Tucci wrote:
> can you not just use field->camelcase_name()
> 

Acknowledged.

[kraynov, 2016-08-05 11:25:07]

The CQ bit was checked by kraynov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 11:25:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kraynov, 2016-08-05 11:33:17]

The CQ bit was unchecked by kraynov@chromium.org

[Primiano Tucci (use gerrit), 2016-08-05 11:34:18]

LGTM. Maybe you could make the commit message a bit less succint.
And say: Expose constants for field numbers in the generated stubs :)

https://codereview.chromium.org/2217703002/diff/20001/components/tracing/tool...
File components/tracing/tools/proto_zero_plugin/proto_zero_generator.cc (right):

https://codereview.chromium.org/2217703002/diff/20001/components/tracing/tool...
components/tracing/tools/proto_zero_plugin/proto_zero_generator.cc:97: inline
std::string GetCamelCaseName(const T* descriptor, bool capitalize) {
looks like capitalize is always = true.
Unless you plan to use this argument in next CLs please drop it.

https://codereview.chromium.org/2217703002/diff/20001/components/tracing/tool...
components/tracing/tools/proto_zero_plugin/proto_zero_generator.cc:484:
Abort("Empty field name in camel case notation.");
lol, TIL

[kraynov, 2016-08-05 11:45:20]

Description was changed from

==========
Tracing V2: Field number constants for protobuf plugin.

Basic reflection capabilities.

BUG=608721
==========

to

==========
Tracing V2: Field number constants for protobuf plugin.

Basic reflection with exposure of original proto field numbers
as constants in the generated stubs.

BUG=608721
==========

[kraynov, 2016-08-05 11:45:41]

The CQ bit was checked by kraynov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 11:45:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kraynov, 2016-08-05 12:01:23]

The CQ bit was unchecked by kraynov@chromium.org

[kraynov, 2016-08-05 12:31:59]

The CQ bit was checked by kraynov@chromium.org

[kraynov, 2016-08-05 12:31:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/2217703002/#ps40001
(title: "remove template")

[commit-bot: I haz the power, 2016-08-05 12:32:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 12:35:25]

Description was changed from

==========
Tracing V2: Field number constants for protobuf plugin.

Basic reflection with exposure of original proto field numbers
as constants in the generated stubs.

BUG=608721
==========

to

==========
Tracing V2: Field number constants for protobuf plugin.

Basic reflection with exposure of original proto field numbers
as constants in the generated stubs.

BUG=608721
==========

[commit-bot: I haz the power, 2016-08-05 12:35:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-05 12:37:16]

Description was changed from

==========
Tracing V2: Field number constants for protobuf plugin.

Basic reflection with exposure of original proto field numbers
as constants in the generated stubs.

BUG=608721
==========

to

==========
Tracing V2: Field number constants for protobuf plugin.

Basic reflection with exposure of original proto field numbers
as constants in the generated stubs.

BUG=608721

Committed: https://crrev.com/437896040998aadd2c85c802a2d85d9b20adde6f
Cr-Commit-Position: refs/heads/master@{#410040}
==========

[commit-bot: I haz the power, 2016-08-05 12:37:17]

Patchset 3 (id:??) landed as
https://crrev.com/437896040998aadd2c85c802a2d85d9b20adde6f
Cr-Commit-Position: refs/heads/master@{#410040}