Allow embedder to use custom ResourceRequestAllowedNotifier

components/web_resource/web_resource_service.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_WEB_RESOURCE_WEB_RESOURCE_SERVICE_H_
 #define COMPONENTS_WEB_RESOURCE_WEB_RESOURCE_SERVICE_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 46 matching lines @@
                      const char* disable_network_switch,
                      const ParseJSONCallback& parse_json_callback);
 
   ~WebResourceService() override;
 
   // Sleep until cache needs to be updated, but always for at least
   // |start_fetch_delay_ms| so we don't interfere with startup.
   // Then begin updating resources.
   void StartAfterDelay();
 
+  // Sets the ResourceRequestAllowedNotifier to make it configurable.
+  void SetResourceRequestAllowedNotifier(
+    std::unique_ptr<ResourceRequestAllowedNotifier> notifier);

[Dan Beam, 2016/08/08 18:15:33]

4\s indent instead of 2\s (add 2 more spaces to the beginning of this line)

+
  protected:
   PrefService* prefs_;
 
  private:
+  friend class WebResourceServiceTest;
+
   // For the subclasses to process the result of a fetch.
   virtual void Unpack(const base::DictionaryValue& parsed_json) = 0;
 
   // net::URLFetcherDelegate implementation:
   void OnURLFetchComplete(const net::URLFetcher* source) override;
 
   // Schedules a fetch after |delay_ms| milliseconds.
   void ScheduleFetch(int64_t delay_ms);
 
   // Starts fetching data from the server.
   void StartFetch();
 
   // Set |in_fetch_| to false, clean up temp directories (in the future).
   void EndFetch();
 
   // Callbacks from the JSON parser.
   void OnUnpackFinished(std::unique_ptr<base::Value> value);
   void OnUnpackError(const std::string& error_message);
 
   // Implements ResourceRequestAllowedNotifier::Observer.
   void OnResourceRequestsAllowed() override;
 
   // Helper class used to tell this service if it's allowed to make network
   // resource requests.
-  ResourceRequestAllowedNotifier resource_request_allowed_notifier_;
+  std::unique_ptr<ResourceRequestAllowedNotifier>
+      resource_request_allowed_notifier_;
+
+  // True if we have scheduled a fetch after start_fetch_delay_ms_
+  // or another one in |cache_update_delay_ms_| time. Set to false
+  // before fetching starts so that next fetch is scheduled. This is
+  // to make sure not more than one fetch is scheduled for given point in time.
+  bool fetch_scheduled_;
 
   // The tool that fetches the url data from the server.
   std::unique_ptr<net::URLFetcher> url_fetcher_;
 
   // True if we are currently fetching or unpacking data. If we are asked to
   // start a fetch when we are still fetching resource data, schedule another
   // one in |cache_update_delay_ms_| time, and silently exit.
   bool in_fetch_;
 
   // URL that hosts the web resource.
@@ skipping 21 matching lines @@
   // So that we can delay our start so as not to affect start-up time; also,
   // so that we can schedule future cache updates.
   base::WeakPtrFactory<WebResourceService> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(WebResourceService);
 };
 
 }  // namespace web_resource
 
 #endif  // COMPONENTS_WEB_RESOURCE_WEB_RESOURCE_SERVICE_H_