Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2217663002: Refactor fx_ge part 1 (Closed)

Created:
4 years, 4 months ago by npm
Modified:
4 years, 4 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move CFX_GEModule into its own file This is the first CL in an attempt to split up the classes in fxge/include/fx_ge.h into their own files. Committed: https://pdfium.googlesource.com/pdfium/+/26b86e625a2c9e0f4e6a01047fef051ffa81e40a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -108 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_type1font.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fxge/agg/fx_agg_driver.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fxge/android/fx_android_imp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fxge/apple/fx_apple_platform.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fxge/apple/fx_mac_imp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fxge/apple/fx_quartz_device.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fxge/dib/fx_dib_composite.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fxge/dib/fx_dib_main.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A + core/fxge/ge/cfx_gemodule.cpp View 1 chunk +1 line, -1 line 0 comments Download
D core/fxge/ge/fx_ge.cpp View 1 chunk +0 lines, -71 lines 0 comments Download
M core/fxge/ge/fx_ge_font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/fx_ge_linux.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/fx_ge_text.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A core/fxge/include/cfx_gemodule.h View 1 chunk +50 lines, -0 lines 0 comments Download
M core/fxge/include/fx_ge.h View 1 chunk +0 lines, -31 lines 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fxge/win32/fx_win32_device.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fxge/win32/fx_win32_dib.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fxge/win32/fx_win32_gdipext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/cfx_systemhandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_sysfontinfo.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M pdfium.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M xfa/fde/fde_gedevice.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OneDimWriter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OnedEAN13Writer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OnedEAN8Writer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OnedUPCAWriter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxgraphics/cfx_graphics.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
npm
PTAL
4 years, 4 months ago (2016-08-04 20:01:55 UTC) #3
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-04 22:48:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217663002/1
4 years, 4 months ago (2016-08-05 00:21:54 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 00:22:19 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/26b86e625a2c9e0f4e6a01047fef051ffa81...

Powered by Google App Engine
This is Rietveld 408576698