Explicitly set is_clang=true on the lkgr win asan bots

Explicitly set is_clang=true on the lkgr win asan bots

In the gyp build, asan=1 implicitly enabled clang.  This should probably happen
in the gn build as well, but currently it doesn't.  Until it does, explicitly
set it on these bots.

Thanks to etienneb@ for spotting this.

BUG=598761
R=etienneb@chromium.org, inferno@chromium.org

Committed: https://crrev.com/b2efa2c67908541d5a1a302283b1a675bf81902b
Cr-Commit-Position: refs/heads/master@{#409866}

[Nico, 2016-08-04 19:09:29]

Description was changed from

==========
Explicitly set is_clang=true on the lkgr win asan bots

In the gyp build, asan=1 implicitly enabled clang.  This should probably happen
in the gn build as well, but currently it doesn't.  Until it does, explicitly
set it on these bots.

BUG=598761
==========

to

==========
Explicitly set is_clang=true on the lkgr win asan bots

In the gyp build, asan=1 implicitly enabled clang.  This should probably happen
in the gn build as well, but currently it doesn't.  Until it does, explicitly
set it on these bots.

Thanks to etienneb@ for spotting this.

BUG=598761
==========

[Nico, 2016-08-04 19:09:46]

thakis@chromium.org changed reviewers:
+ etienneb@chromium.org

[Nico, 2016-08-04 19:09:58]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 19:10:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[etienneb, 2016-08-04 19:16:09]

lgtm

[Nico, 2016-08-04 19:17:45]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2016-08-04 19:17:59]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-08-04 19:18:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[inferno, 2016-08-04 19:23:10]

inferno@chromium.org changed reviewers:
+ inferno@chromium.org

[inferno, 2016-08-04 19:23:10]

lgtm.

[Nico, 2016-08-04 19:34:25]

Description was changed from

==========
Explicitly set is_clang=true on the lkgr win asan bots

In the gyp build, asan=1 implicitly enabled clang.  This should probably happen
in the gn build as well, but currently it doesn't.  Until it does, explicitly
set it on these bots.

Thanks to etienneb@ for spotting this.

BUG=598761
==========

to

==========
Explicitly set is_clang=true on the lkgr win asan bots

In the gyp build, asan=1 implicitly enabled clang.  This should probably happen
in the gn build as well, but currently it doesn't.  Until it does, explicitly
set it on these bots.

Thanks to etienneb@ for spotting this.

BUG=598761
R=etienneb@chromium.org, inferno@chromium.org
==========

[Nico, 2016-08-04 19:34:26]

Committed patchset #1 (id:1) to pending queue manually as
c9101d13c3dbf27011de99cdc32d49e8061a64b9 (presubmit successful).

[commit-bot: I haz the power, 2016-08-04 19:34:57]

Description was changed from

==========
Explicitly set is_clang=true on the lkgr win asan bots

In the gyp build, asan=1 implicitly enabled clang.  This should probably happen
in the gn build as well, but currently it doesn't.  Until it does, explicitly
set it on these bots.

Thanks to etienneb@ for spotting this.

BUG=598761
R=etienneb@chromium.org, inferno@chromium.org
==========

to

==========
Explicitly set is_clang=true on the lkgr win asan bots

In the gyp build, asan=1 implicitly enabled clang.  This should probably happen
in the gn build as well, but currently it doesn't.  Until it does, explicitly
set it on these bots.

Thanks to etienneb@ for spotting this.

BUG=598761
R=etienneb@chromium.org, inferno@chromium.org

Committed: https://crrev.com/b2efa2c67908541d5a1a302283b1a675bf81902b
Cr-Commit-Position: refs/heads/master@{#409866}
==========

[commit-bot: I haz the power, 2016-08-04 19:34:58]

Patchset 1 (id:??) landed as
https://crrev.com/b2efa2c67908541d5a1a302283b1a675bf81902b
Cr-Commit-Position: refs/heads/master@{#409866}

[Dirk Pranke, 2016-08-04 19:36:54]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-08-04 19:36:54]

Ah, whoops, good catch.

+brettw for context ...

We can't easily make is_clang=true when is_asan==true in the GN build, because
is_clang is an arg declared in BUILDCONFIG.gn, and is_asan is declared in
sanitizers.gni. We are trying to keep all of the sanitizer-related settings out
of BUILDCONFIG.gn, but that means we end up with some limitations as a result
...

[brettw, 2016-08-04 22:14:13]

On 2016/08/04 19:36:54, Dirk Pranke wrote:
> Ah, whoops, good catch.
> 
> +brettw for context ...
> 
> We can't easily make is_clang=true when is_asan==true in the GN build, because
> is_clang is an arg declared in BUILDCONFIG.gn, and is_asan is declared in
> sanitizers.gni. We are trying to keep all of the sanitizer-related settings
out
> of BUILDCONFIG.gn, but that means we end up with some limitations as a result
> ...

In such cases I think the best thing is an assert in the sanitizer setup that
makes sure the current combination of flags is reasonable.

[Nico, 2016-08-04 22:17:37]

On 2016/08/04 22:14:13, brettw (ping on IM after 24h) wrote:
> On 2016/08/04 19:36:54, Dirk Pranke wrote:
> > Ah, whoops, good catch.
> > 
> > +brettw for context ...
> > 
> > We can't easily make is_clang=true when is_asan==true in the GN build,
because
> > is_clang is an arg declared in BUILDCONFIG.gn, and is_asan is declared in
> > sanitizers.gni. We are trying to keep all of the sanitizer-related settings
> out
> > of BUILDCONFIG.gn, but that means we end up with some limitations as a
result
> > ...
> 
> In such cases I think the best thing is an assert in the sanitizer setup that
> makes sure the current combination of flags is reasonable.

Yeah we have an assert, but it's still more awkward to use than previously.