Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2217643002: Render extension URLs similar to EV certs (Closed)

Created:
4 years, 4 months ago by meacer
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Render extension URLs similar to EV certs BUG=453093

Patch Set 1 #

Patch Set 2 : Mac #

Patch Set 3 : Add extension name #

Patch Set 4 : Fix tests #

Patch Set 5 : Unbreak tests #

Patch Set 6 : Remove minimum width #

Patch Set 7 : Fix build #

Patch Set 8 : Sanitize #

Patch Set 9 : Remove #

Patch Set 10 : Fix mac #

Patch Set 11 : Rebase #

Patch Set 12 : Rebase #

Patch Set 13 : Rebase and resolve pkasting comments #

Patch Set 14 : pkasting comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -29 lines) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +18 lines, -3 lines 0 comments Download
M chrome/browser/ui/location_bar/location_bar.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/location_bar/location_bar.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +24 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +11 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 6 chunks +21 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_icon_view.h View 1 2 3 4 5 6 7 8 9 10 12 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_icon_view.cc View 1 2 3 4 5 6 7 8 9 10 12 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/window_update/resize/test.js View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M components/toolbar/toolbar_model_impl.cc View 1 2 3 4 5 6 7 8 9 10 12 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 52 (52 generated)
meacer
The CQ bit was checked by meacer@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-05 18:26:04 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217643002/40001
4 years, 4 months ago (2016-08-05 18:26:18 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-05 18:53:45 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/213488)
4 years, 4 months ago (2016-08-05 18:53:46 UTC) #4
meacer
The CQ bit was checked by meacer@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-05 19:07:23 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217643002/60001
4 years, 4 months ago (2016-08-05 19:08:07 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-05 19:44:09 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/213517)
4 years, 4 months ago (2016-08-05 19:44:10 UTC) #8
meacer
The CQ bit was checked by meacer@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-08 17:31:59 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217643002/80001
4 years, 4 months ago (2016-08-08 17:32:27 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-08 18:08:23 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/275908)
4 years, 4 months ago (2016-08-08 18:08:24 UTC) #12
meacer
The CQ bit was checked by meacer@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-08 22:51:18 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217643002/100001
4 years, 4 months ago (2016-08-08 22:52:04 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-08 23:05:02 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/243097)
4 years, 4 months ago (2016-08-08 23:05:03 UTC) #16
meacer
The CQ bit was checked by meacer@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-09 00:33:13 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217643002/120001
4 years, 4 months ago (2016-08-09 00:33:43 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-09 00:41:52 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/180237)
4 years, 4 months ago (2016-08-09 00:41:53 UTC) #20
meacer
The CQ bit was checked by meacer@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-09 05:45:03 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217643002/120001
4 years, 4 months ago (2016-08-09 05:45:20 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-09 06:16:08 UTC) #23
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 4 months ago (2016-08-09 06:16:09 UTC) #24
meacer
The CQ bit was checked by meacer@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-15 18:57:37 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217643002/140001
4 years, 4 months ago (2016-08-15 18:57:58 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-15 19:02:44 UTC) #27
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/52142) ios-simulator on ...
4 years, 4 months ago (2016-08-15 19:02:45 UTC) #28
meacer
The CQ bit was checked by meacer@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-16 21:51:02 UTC) #29
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217643002/160001
4 years, 4 months ago (2016-08-16 21:51:27 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-16 22:28:10 UTC) #31
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/252275)
4 years, 4 months ago (2016-08-16 22:28:11 UTC) #32
meacer
The CQ bit was checked by meacer@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-16 22:37:43 UTC) #33
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217643002/180001
4 years, 4 months ago (2016-08-16 22:38:03 UTC) #34
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-16 23:02:43 UTC) #35
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/252324)
4 years, 4 months ago (2016-08-16 23:02:44 UTC) #36
meacer
The CQ bit was checked by meacer@chromium.org to run a CQ dry run
4 years ago (2016-12-15 01:25:43 UTC) #37
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217643002/200001
4 years ago (2016-12-15 01:25:57 UTC) #38
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-15 01:28:09 UTC) #39
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/123248) ios-device-xcode-clang on ...
4 years ago (2016-12-15 01:28:10 UTC) #40
meacer
The CQ bit was checked by meacer@chromium.org to run a CQ dry run
4 years ago (2016-12-15 01:34:15 UTC) #41
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217643002/220001
4 years ago (2016-12-15 01:34:36 UTC) #42
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-15 01:39:51 UTC) #43
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/139107)
4 years ago (2016-12-15 01:39:52 UTC) #44
meacer
The CQ bit was checked by meacer@chromium.org to run a CQ dry run
4 years ago (2016-12-16 00:44:02 UTC) #45
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217643002/240001
4 years ago (2016-12-16 00:45:04 UTC) #46
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-16 02:46:00 UTC) #47
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years ago (2016-12-16 02:46:01 UTC) #48
meacer
The CQ bit was checked by meacer@chromium.org to run a CQ dry run
4 years ago (2016-12-20 19:58:40 UTC) #49
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217643002/260001
4 years ago (2016-12-20 19:59:14 UTC) #50
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-20 22:47:14 UTC) #51
commit-bot: I haz the power
4 years ago (2016-12-20 22:47:15 UTC) #52 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698