Issue 221763002: Revert of Fix typo in MockSpellCheck::misspelledWords

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 221763002: Revert of Fix typo in MockSpellCheck::misspelledWords (Closed)

Created:
6 years, 8 months ago by pfeldman

Modified:
6 years, 8 months ago

Reviewers:
Dirk Pranke, Tommy Widenflycht, groby-ooo-7-16, grzegorz, abarth-chromium, tony

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Revert of Fix typo in MockSpellCheck::misspelledWords (https://codereview.chromium.org/214153005/) Reason for revert: Breaks test upstream: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&showExpectations=true&tests=editing%2Fselection%2F13804.html Original issue's description: > Fix typo in MockSpellCheck::misspelledWords > > Replace 'asd' into 'asdf' since editing/spelling/design-mode-spellcheck-off.html > is using it. > The test was always passing as it expects not to have spelling markers due to > <body spellcheck=false> > > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260835 TBR=tony@chromium.org,groby@chromium.org,abarth@chromium.org,dpranke@chromium.org,tommyw@chromium.org,g.czajkowski@samsung.com NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261073

Created: 6 years, 8 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/shell/renderer/test_runner/MockSpellCheck.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

pfeldman

Created Revert of Fix typo in MockSpellCheck::misspelledWords

6 years, 8 months ago (2014-04-02 04:08:25 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/221763002/1

6 years, 8 months ago (2014-04-02 04:08:58 UTC) #2

pfeldman

6 years, 8 months ago (2014-04-02 04:27:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r261073 (tree was closed).