Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 2217563002: Make the WinASan bots 32-bit again (Closed)

Created:
4 years, 4 months ago by Reid Kleckner
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, Nico
CC:
chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the WinASan bots 32-bit again This got lost in the gyp-to-gn flip, because gn is x64 by default. R=thakis@chromium.org NOTRY=true BUG=598761 Committed: https://crrev.com/9c263a45e736e6b44b04a4bf90edd5944a1df432 Cr-Commit-Position: refs/heads/master@{#409860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/mb/mb_config.pyl View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Reid Kleckner
4 years, 4 months ago (2016-08-04 17:51:31 UTC) #1
Nico
lgtm, nice find :-) I'm a bit surprised by this tbh. The bots have been ...
4 years, 4 months ago (2016-08-04 17:58:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217563002/1
4 years, 4 months ago (2016-08-04 17:59:02 UTC) #4
Dirk Pranke
lgtm. sigh. GYP builds default to x86, GN to x64, which is why this wasn't ...
4 years, 4 months ago (2016-08-04 18:23:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217563002/1
4 years, 4 months ago (2016-08-04 19:11:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 19:16:44 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 19:19:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c263a45e736e6b44b04a4bf90edd5944a1df432
Cr-Commit-Position: refs/heads/master@{#409860}

Powered by Google App Engine
This is Rietveld 408576698