[battor_agent] Clear pending read buffer if it contains an irrevocable error.

On certain platforms (ok really just on Mac), the serial connection can contain
old data from a previous serial connection. This means that the first bytes
read will be garbage from a prior connection. Previously, could have lead to an
irrevocable error and the message reads would just fail over and over because
the pending read buffer contains such an error. This CL fixes this problem by
clearingo out the pending read buffer when it contains an irrevocable error.

BUG=634188

[aschulman, 2016-08-04 15:52:11]

Description was changed from

==========
[battor_agent] Clear pending read buffer if it contains an irrevocable error.

On certain platforms (ok really just on Mac), the serial connection can contain
old data from a previous serial connection. This means that the first bytes
read will be garbage from a prior connection. Previously, could have lead to an
irrevocable error and the message reads would just fail over and over because
the pending read buffer contains such an error. This CL fixes this problem by
clearingo out the pending read buffer when it contains an irrevocable error.

BUG=
==========

to

==========
[battor_agent] Clear pending read buffer if it contains an irrevocable error.

On certain platforms (ok really just on Mac), the serial connection can contain
old data from a previous serial connection. This means that the first bytes
read will be garbage from a prior connection. Previously, could have lead to an
irrevocable error and the message reads would just fail over and over because
the pending read buffer contains such an error. This CL fixes this problem by
clearingo out the pending read buffer when it contains an irrevocable error.

BUG=634188
==========

[aschulman, 2016-08-04 15:52:11]

aschulman@chromium.org changed reviewers:
+ charliea@chromium.org

[aschulman, 2016-08-04 15:55:33]

On 2016/08/04 15:53:47, aschulman wrote:

I guess maybe it would be good to also add a test case for this, what do you
think?

[charliea (OOO until 10-5), 2016-08-04 16:33:10]

On 2016/08/04 15:55:33, aschulman wrote:
> On 2016/08/04 15:53:47, aschulman wrote:
> 
> I guess maybe it would be good to also add a test case for this, what do you
> think?

I think that's a good idea: I don't think it would be too difficult.

[aschulman, 2016-08-05 22:59:10]

Description was changed from

==========
[battor_agent] Clear pending read buffer if it contains an irrevocable error.

On certain platforms (ok really just on Mac), the serial connection can contain
old data from a previous serial connection. This means that the first bytes
read will be garbage from a prior connection. Previously, could have lead to an
irrevocable error and the message reads would just fail over and over because
the pending read buffer contains such an error. This CL fixes this problem by
clearingo out the pending read buffer when it contains an irrevocable error.

BUG=634188
==========

to

==========
On certain platforms (ok really just on Mac), the serial connection can contain
old data from a previous serial connection. This means that the first bytes
read will be garbage from a prior connection. Previously, could have lead to an
irrevocable error and the message reads would just fail over and over because
the pending read buffer contains such an error. This CL fixes this problem by
clearingo out the pending read buffer when it contains an irrevocable error.

BUG=634188
==========

[charliea (OOO until 10-5), 2016-10-10 14:26:19]

Removing myself, as I don't think this is still relevant: please feel free to
add me back if I should review it

[aschulman, 2016-10-26 07:21:38]

aschulman@chromium.org changed reviewers:
- charliea@chromium.org