Revert of MD Settings: Adding some unit tests for <settings-main>.

chrome/test/data/webui/settings/settings_main_test.js

Index: chrome/test/data/webui/settings/settings_main_test.js
diff --git a/chrome/test/data/webui/settings/settings_main_test.js b/chrome/test/data/webui/settings/settings_main_test.js
deleted file mode 100644
index 0ae1912e3942f7f09ffc78772b7fbeb5ae55c2bb..0000000000000000000000000000000000000000
--- a/chrome/test/data/webui/settings/settings_main_test.js
+++ /dev/null
@@ -1,103 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-cr.define('settings_main_page', function() {
-  /**
-   * @implements {SearchManager}
-   */
-  var TestSearchManager = function() {
-    /** @private {boolean} */
-    this.matchesFound_ = true;
-
-    /** @private {?settings.SearchRequest} */
-    this.searchRequest_ = null;
-  }
-
-  TestSearchManager.prototype = {
-    /**
-     * @param {boolean} matchesFound
-     */
-    setMatchesFound: function(matchesFound) {
-      this.matchesFound_ = matchesFound;
-    },
-
-    /** @override */
-    search: function(text, page) {
-      if (this.searchRequest_ == null || !this.searchRequest_.isSame(text)) {
-        this.searchRequest_ = new settings.SearchRequest(text);
-        this.searchRequest_.finished = true;
-        this.searchRequest_.updateMatches(this.matchesFound_);
-        this.searchRequest_.resolver.resolve(this.searchRequest_);
-      }
-      return this.searchRequest_.resolver.promise;
-    },
-  };
-
-  function registerTests() {
-    var settingsPrefs = null;
-
-    suiteSetup(function() {
-      settingsPrefs = document.createElement('settings-prefs');
-    });
-
-    suite('SearchTests', function() {
-      /** @type {?TestSearchManager} */
-      var searchManager = null;
-
-      /** @type {?SettingsMainElement} */
-      var settingsMain = null;
-
-      // TODO(tommycli): Remove once settings.navigateTo is no longer a stub.
-      settings.navigateTo = function(route) {
-        settingsMain.currentRoute = route;
-      };
-
-      setup(function() {
-        searchManager = new TestSearchManager();
-        settings.setSearchManagerForTesting(searchManager);
-        PolymerTest.clearBody();
-        settingsMain = document.createElement('settings-main');
-        settingsMain.prefs = settingsPrefs.prefs;

[michaelpg, 2016/08/04 18:10:17]

I think we need to create the <settings-prefs> after <settings-main>; if we
create it too early, the browser could respond with the prefs, causing
CrSettingsPrefs.initialized to resolve... so when we create <settings-main> all
the pref controls think the prefs should be available before we even set the
prefs property.

this is likely since setup() is called before each test, and the tests are
async.

you could test this by returning CrSettingsPrefs.initialized in suiteSetup(),
which would force the test to wait until the prefs come back from the browser...
at that point creating settings-main should fail 100% of the time.

You may then have to call settingsPrefs.resetForTesting() in the teardown, as
otherwise creating the new settings-main would fail.

-        settingsMain.toolbarSpinnerActive = false;
-        document.body.appendChild(settingsMain);
-      });
-
-      teardown(function() { settingsMain.remove(); });
-
-      test('no results page shows and hides', function() {
-        var noSearchResults = settingsMain.$.noSearchResults;
-        assertTrue(!!noSearchResults);
-        assertTrue(noSearchResults.hidden);
-
-        searchManager.setMatchesFound(false);
-        return settingsMain.searchContents('Query1').then(function() {
-          assertFalse(noSearchResults.hidden);
-
-          searchManager.setMatchesFound(true);
-          return settingsMain.searchContents('Query2');
-        }).then(function() {
-          assertTrue(noSearchResults.hidden);
-        });
-      });
-
-      // Ensure that when the user clears the search box, the "no results" page
-      // is hidden.
-      test('no results page hides on clear', function() {
-        var noSearchResults = settingsMain.$.noSearchResults;
-        assertTrue(!!noSearchResults);
-        assertTrue(noSearchResults.hidden);
-        searchManager.setMatchesFound(false);
-
-        // Clearing the search box is effectively a search for the empty string.
-        return settingsMain.searchContents('').then(function() {
-          assertTrue(noSearchResults.hidden);
-        });
-      });
-    });
-  }
-
-  return {
-    registerTests: registerTests,
-  };
-});