Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 2217453002: Put a prototype class of DOMException (Closed)

Created:
4 years, 4 months ago by peria
Modified:
4 years, 4 months ago
Reviewers:
haraken, Yuki, tzik
CC:
chromium-reviews, blink-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Put a prototype class of DOMException. We have no declaration of DOMException in header files recursively included from ErrorCallback.h. Compiles passed well by chance. BUG=634231 Committed: https://crrev.com/2a213fd43d3915932361089a18ffdca4390775d4 Cr-Commit-Position: refs/heads/master@{#409782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/filesystem/ErrorCallback.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
peria
PTL.
4 years, 4 months ago (2016-08-04 13:05:22 UTC) #3
tzik
lgtm
4 years, 4 months ago (2016-08-04 13:08:03 UTC) #4
haraken
LGTM
4 years, 4 months ago (2016-08-04 13:09:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217453002/1
4 years, 4 months ago (2016-08-04 13:13:07 UTC) #7
Yuki
lgtm
4 years, 4 months ago (2016-08-04 13:13:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 14:38:35 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 14:41:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a213fd43d3915932361089a18ffdca4390775d4
Cr-Commit-Position: refs/heads/master@{#409782}

Powered by Google App Engine
This is Rietveld 408576698