Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 221743006: Deflake fast/css-generated-content/malformed-url.html (Closed)

Created:
6 years, 8 months ago by esprehn
Modified:
6 years, 8 months ago
Reviewers:
ojan
CC:
blink-reviews
Visibility:
Public.

Description

Deflake fast/css-generated-content/malformed-url.html This test was flaky because it would sometimes print the url of the blocked resource and sometimes not depending on when the navigation happened. Instead we should wait for onload so that the url is always printed. TBR=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170710

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M LayoutTests/fast/css-generated-content/malformed-url.html View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 8 months ago (2014-04-02 21:27:32 UTC) #1
esprehn
6 years, 8 months ago (2014-04-02 21:27:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/221743006/1
6 years, 8 months ago (2014-04-02 21:27:41 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 21:38:16 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 8 months ago (2014-04-02 21:38:17 UTC) #5
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 8 months ago (2014-04-02 21:41:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/221743006/1
6 years, 8 months ago (2014-04-02 21:41:44 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 22:35:14 UTC) #8
Message was sent while issue was closed.
Change committed as 170710

Powered by Google App Engine
This is Rietveld 408576698