Issue 221743005: Check in Lithium that allocation size in Smi range.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 221743005: Check in Lithium that allocation size in Smi range. (Closed)

Created:
6 years, 8 months ago by Jarin

Modified:
6 years, 8 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Check in Lithium that allocation size in Smi range. This is to avoid triggering an assertion from Smi::FromInt. The generated code is unreachable, so it is not a real bug. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20458

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -11 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+7 lines, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-alloc-smi-check.js	View	1 chunk	+9 lines, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

Jarin

6 years, 8 months ago (2014-04-03 07:04:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20458 (presubmit successful).