chrome/browser/resources/settings/settings_page/settings_animated_pages.js - Issue 2217403002: MD Settings: Tune searching algorithm to skip certain subpages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_animated_pages.js

Issue 2217403002: MD Settings: Tune searching algorithm to skip certain subpages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge conflicts. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_settings.js ('k') | chrome/browser/resources/settings/settings_page/settings_subpage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/settings_animated_pages.js

diff --git a/chrome/browser/resources/settings/settings_page/settings_animated_pages.js b/chrome/browser/resources/settings/settings_page/settings_animated_pages.js

index 682ead2dc14c8c474601fbe74938ce5aba6b00c1..b81f96595e4351199faed9e6bd80307cf8a02d03 100644

--- a/chrome/browser/resources/settings/settings_page/settings_animated_pages.js

+++ b/chrome/browser/resources/settings/settings_page/settings_animated_pages.js

@@ -147,6 +147,9 @@ Polymer({

.querySelector('settings-subpage');

if (!subpage.id)

subpage.id = id;

+ if (template.hasAttribute('skip-search')) {

Dan Beam 2016/08/06 01:50:27 no curlies

Dan Beam 2016/08/06 01:50:27 i guess this isn't a bad idea, but maybe just repe

dpapad 2016/08/08 17:27:01 Carrying over the 'no-search' attribute once progr

Dan Beam 2016/08/08 17:42:55 that's fine

dpapad 2016/08/08 18:15:20 Done.

+ subpage.setAttribute('skip-search', '');

+ }

// Render synchronously so neon-animated-pages can select the subpage.

template.if = true;