chrome/browser/resources/settings/people_page/people_page.html - Issue 2217403002: MD Settings: Tune searching algorithm to skip certain subpages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/people_page.html

Issue 2217403002: MD Settings: Tune searching algorithm to skip certain subpages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/languages_page/languages_page.html ('k') | chrome/browser/resources/settings/printing_page/printing_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/people_page.html

diff --git a/chrome/browser/resources/settings/people_page/people_page.html b/chrome/browser/resources/settings/people_page/people_page.html

index 9e853a107c37d545e1a0f4876be4d98a169c2e59..ac843ffc93607bf7c56cbbb4ffbebd8c7ad9bfe4 100644

--- a/chrome/browser/resources/settings/people_page/people_page.html

+++ b/chrome/browser/resources/settings/people_page/people_page.html

@@ -169,7 +169,7 @@

<!-- TODO(jdufault): Disable navigating to /quickUnlock/* if pin is

disabled. -->

- <div id="quick-unlock-subpage-trigger" class="settings-box">

+ <div class="settings-box">

<paper-button on-tap="onQuickUnlockTap_" class="primary-button">

$i18n{quickUnlockTitle}

</paper-button>

@@ -242,27 +242,23 @@

</settings-subpage>

</template>

- <template is="dom-if" name="quick-unlock-authenticate">

- <settings-subpage

- associated-control="[[$$('#quick-unlock-subpage-trigger')]]"

- page-title="$i18n{quickUnlockTitle}">

+ <template is="dom-if" name="quick-unlock-authenticate" no-search>

+ <settings-subpage page-title="$i18n{quickUnlockTitle}">

<settings-quick-unlock-authenticate

set-modes="{{quickUnlockSetModes}}"

profile-name="[[profileName_]]">

</settings-quick-unlock-authenticate>

</settings-subpage>

</template>

- <template is="dom-if" name="quick-unlock-choose-method">

- <settings-subpage no-associated-control

- page-title="$i18n{quickUnlockTitle}">

+ <template is="dom-if" name="quick-unlock-choose-method" no-search>

+ <settings-subpage page-title="$i18n{quickUnlockTitle}">

<settings-quick-unlock-choose-method

set-modes="[[quickUnlockSetModes]]" prefs="{{prefs}}">

</settings-quick-unlock-choose-method>

</settings-subpage>

</template>

- <template is="dom-if" name="quick-unlock-setup-pin">

- <settings-subpage no-associated-control

- page-title="$i18n{quickUnlockTitle}">

+ <template is="dom-if" name="quick-unlock-setup-pin" no-search>

+ <settings-subpage page-title="$i18n{quickUnlockTitle}">

<settings-quick-unlock-setup-pin set-modes="[[quickUnlockSetModes]]">

</settings-quick-unlock-setup-pin>

</settings-subpage>