MD Settings: Tune searching algorithm to skip certain subpages.

chrome/browser/resources/settings/settings_page/settings_animated_pages.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-animated-pages' is a container for a page and animated subpages.
  * It provides a set of common behaviors and animations.
  *
  * Example:
@@ skipping 129 matching lines @@
     // Nothing to do if the subpage isn't wrapped in a <template> or the
     // template is already stamped.
     if (!template || template.if)
       return;
 
     // Set the subpage's id for use by neon-animated-pages.
     var subpage = /** @type {{_content: DocumentFragment}} */(template)._content
         .querySelector('settings-subpage');
     if (!subpage.id)
       subpage.id = id;
+    if (template.hasAttribute('skip-search')) {

[Dan Beam, 2016/08/06 01:50:27]

no curlies

[Dan Beam, 2016/08/06 01:50:27]

i guess this isn't a bad idea, but maybe just repeating the attribute in the
subpage in the HTML would be more intuitive

[dpapad, 2016/08/08 17:27:01]

Carrying over the 'no-search' attribute once programmatically, seems less
redundant and therefore less error-prone than copying it over manually in
multiple occasions. 

How about adding a comment here explaining why this attribute is copied instead?

[Dan Beam, 2016/08/08 17:42:55]

that's fine

[dpapad, 2016/08/08 18:15:20]

Done.

+      subpage.setAttribute('skip-search', '');
+    }
 
     // Render synchronously so neon-animated-pages can select the subpage.
     template.if = true;
     template.render();
   },
 });