Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_subpage.js

Issue 2217403002: MD Settings: Tune searching algorithm to skip certain subpages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_page/settings_animated_pages.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-subpage' shows a subpage beneath a subheader. The header contains 7 * 'settings-subpage' shows a subpage beneath a subheader. The header contains
8 * the subpage title and a back icon. The back icon fires an event which 8 * the subpage title and a back icon. The back icon fires an event which
9 * is caught by settings-animated-pages, so it requires no separate handling. 9 * is caught by settings-animated-pages, so it requires no separate handling.
10 */ 10 */
(...skipping 12 matching lines...) Expand all
23 23
24 /** Setting a |searchLabel| will enable search. */ 24 /** Setting a |searchLabel| will enable search. */
25 searchLabel: String, 25 searchLabel: String,
26 26
27 searchTerm: { 27 searchTerm: {
28 type: String, 28 type: String,
29 notify: true, 29 notify: true,
30 value: '', 30 value: '',
31 }, 31 },
32 32
33 /** @type {?HTMLElement} */ 33 /**
34 * Indicates which element triggers this subpage. Used by the searching
35 * algorithm to show search bubbles. It is |null| for subpages that are
36 * skipped during searching.
37 * @type {?HTMLElement}
38 */
34 associatedControl: { 39 associatedControl: {
35 type: Object, 40 type: Object,
36 value: null, 41 value: null,
37 }, 42 },
38
39 /**
40 * Indicates whether an associated control (an element that triggers the
41 * subpage) is not registered for this page. Used by the searching algorithm
42 * to show search bubbles.
43 */
44 noAssociatedControl: {
45 type: Boolean,
46 value: false,
47 },
48 }, 43 },
49 44
50 /** @private */ 45 /** @private */
51 onTapBack_: function() { 46 onTapBack_: function() {
52 // Event is caught by settings-animated-pages. 47 // Event is caught by settings-animated-pages.
53 this.fire('subpage-back'); 48 this.fire('subpage-back');
54 }, 49 },
55 50
56 /** @private */ 51 /** @private */
57 onSearchChanged_: function(e) { 52 onSearchChanged_: function(e) {
58 this.searchTerm = e.detail; 53 this.searchTerm = e.detail;
59 }, 54 },
60 }); 55 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/settings_page/settings_animated_pages.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698