Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2217393002: Change default Windows compiler to MSVS 2015 (VS version 14.0) (Closed)

Created:
4 years, 4 months ago by Bill Hesse
Modified:
4 years, 4 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change default Windows compiler to MSVS 2015 (VS version 14.0) BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/e82a20b1801da638061c946026e3654aeccfa588

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/utils.py View 2 chunks +3 lines, -3 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
4 years, 4 months ago (2016-08-05 22:08:29 UTC) #2
zra
lgtm with nit https://codereview.chromium.org/2217393002/diff/1/tools/utils.py File tools/utils.py (right): https://codereview.chromium.org/2217393002/diff/1/tools/utils.py#newcode152 tools/utils.py:152: # Stop search since if we ...
4 years, 4 months ago (2016-08-05 22:11:16 UTC) #3
Bill Hesse
4 years, 4 months ago (2016-08-05 22:13:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e82a20b1801da638061c946026e3654aeccfa588 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698