Issue 2217393002: Change default Windows compiler to MSVS 2015 (VS version 14.0)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2217393002: Change default Windows compiler to MSVS 2015 (VS version 14.0) (Closed)

Created:
4 years, 4 months ago by Bill Hesse

Modified:
4 years, 4 months ago

Reviewers:
zra

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Change default Windows compiler to MSVS 2015 (VS version 14.0) BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/e82a20b1801da638061c946026e3654aeccfa588

Patch Set 1 #

Total comments: 1

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tools/utils.py	View		2 chunks	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

lgtm with nit https://codereview.chromium.org/2217393002/diff/1/tools/utils.py File tools/utils.py (right): https://codereview.chromium.org/2217393002/diff/1/tools/utils.py#newcode152 tools/utils.py:152: # Stop search since if we ...

4 years, 4 months ago (2016-08-05 22:11:16 UTC) #3

Bill Hesse

4 years, 4 months ago (2016-08-05 22:13:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e82a20b1801da638061c946026e3654aeccfa588 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages