Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2217373002: [chromecast] Cleanup include_rules. (Closed)

Created:
4 years, 4 months ago by alokp
Modified:
4 years, 4 months ago
Reviewers:
halliwell, Simeon
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, gfhuang+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromecast] Cleanup include_rules. TBR=vollick Committed: https://crrev.com/a8df79f8bb6f6ea7cafd35494402f8a779034d4d Cr-Commit-Position: refs/heads/master@{#410215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -18 lines) Patch
M chromecast/android/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/app/DEPS View 1 chunk +5 lines, -1 line 0 comments Download
M chromecast/browser/DEPS View 2 chunks +8 lines, -3 lines 0 comments Download
M chromecast/browser/test/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/media/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M chromecast/media/cma/DEPS View 1 chunk +1 line, -2 lines 0 comments Download
M chromecast/media/cma/decoder/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/public/DEPS View 1 chunk +5 lines, -4 lines 0 comments Download
M chromecast/renderer/media/DEPS View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
alokp
4 years, 4 months ago (2016-08-05 21:07:03 UTC) #2
halliwell
On 2016/08/05 21:07:03, alokp wrote: lgtm
4 years, 4 months ago (2016-08-05 21:11:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217373002/1
4 years, 4 months ago (2016-08-05 22:43:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 23:45:37 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 23:46:51 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a8df79f8bb6f6ea7cafd35494402f8a779034d4d
Cr-Commit-Position: refs/heads/master@{#410215}

Powered by Google App Engine
This is Rietveld 408576698