content/renderer/accessibility/render_accessibility_impl.h - Issue 2217363002: Use relative bounding boxes throughout Chrome accessibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/render_accessibility_impl.h

Issue 2217363002: Use relative bounding boxes throughout Chrome accessibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback from aboxhall Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/accessibility/blink_ax_tree_source.cc ('k') | content/renderer/accessibility/render_accessibility_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/render_accessibility_impl.h

diff --git a/content/renderer/accessibility/render_accessibility_impl.h b/content/renderer/accessibility/render_accessibility_impl.h

index 002da728a9155e3d63fee7b4e160e8322f250b2d..bd7e0cb9b4884ddfae23cf78f6cf4df4dabb6155 100644

--- a/content/renderer/accessibility/render_accessibility_impl.h

+++ b/content/renderer/accessibility/render_accessibility_impl.h

@@ -15,6 +15,7 @@

#include "content/public/renderer/render_frame_observer.h"

#include "content/renderer/accessibility/blink_ax_tree_source.h"

#include "third_party/WebKit/public/web/WebAXObject.h"

+#include "ui/accessibility/ax_relative_bounds.h"

#include "ui/accessibility/ax_tree.h"

#include "ui/accessibility/ax_tree_serializer.h"

#include "ui/gfx/geometry/rect_f.h"

@@ -153,7 +154,7 @@ class CONTENT_EXPORT RenderAccessibilityImpl

PdfAXTreeSource* pdf_tree_source_;

// Current location of every object, so we can detect when it moves.

- base::hash_map<int, gfx::RectF> locations_;

+ base::hash_map<int, ui::AXRelativeBounds> locations_;

// The most recently observed scroll offset of the root document element.

// TODO(dmazzoni): remove once https://bugs.webkit.org/show_bug.cgi?id=73460