content/browser/web_contents/web_contents_android.cc - Issue 2217363002: Use relative bounding boxes throughout Chrome accessibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_android.cc

Issue 2217363002: Use relative bounding boxes throughout Chrome accessibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback from aboxhall Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_android.cc

diff --git a/content/browser/web_contents/web_contents_android.cc b/content/browser/web_contents/web_contents_android.cc

index f929fbf6a1153c06419e5fe9d097b1eb2c5b942b..e71b9159f587d56cbdfe3f6f1839672989058694 100644

--- a/content/browser/web_contents/web_contents_android.cc

+++ b/content/browser/web_contents/web_contents_android.cc

@@ -109,7 +109,7 @@ ScopedJavaLocalRef<jobject> WalkAXTreeDepthFirst(

text_style = node->GetIntAttribute(ui::AX_ATTR_TEXT_STYLE);

}

- const gfx::Rect& absolute_rect = node->GetLocalBoundsRect();

+ const gfx::Rect& absolute_rect = node->GetPageBoundsRect();

gfx::Rect parent_relative_rect = absolute_rect;

bool is_root = node->GetParent() == nullptr;

if (!is_root) {

« no previous file with comments | « content/browser/accessibility/browser_accessibility_win.cc ('k') | content/common/accessibility_messages.h » ('j') | no next file with comments »