content/browser/accessibility/browser_accessibility_manager_android.cc - Issue 2217363002: Use relative bounding boxes throughout Chrome accessibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_android.cc

Issue 2217363002: Use relative bounding boxes throughout Chrome accessibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback from aboxhall Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager.cc ('k') | content/browser/accessibility/browser_accessibility_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_manager_android.cc b/content/browser/accessibility/browser_accessibility_manager_android.cc

index e34d36a0d88e8f0f15a2fe1fab96d9ad61989319..6253e4e630077ae9a13ffad0dfbb44e066663798 100644

--- a/content/browser/accessibility/browser_accessibility_manager_android.cc

+++ b/content/browser/accessibility/browser_accessibility_manager_android.cc

@@ -440,10 +440,10 @@ jboolean BrowserAccessibilityManagerAndroid::PopulateAccessibilityNodeInfo(

base::android::ConvertUTF16ToJavaString(env, element_id).obj());

}

- gfx::Rect absolute_rect = node->GetLocalBoundsRect();

+ gfx::Rect absolute_rect = node->GetPageBoundsRect();

gfx::Rect parent_relative_rect = absolute_rect;

if (node->GetParent()) {

- gfx::Rect parent_rect = node->GetParent()->GetLocalBoundsRect();

+ gfx::Rect parent_rect = node->GetParent()->GetPageBoundsRect();

parent_relative_rect.Offset(-parent_rect.OffsetFromOrigin());

}

bool is_root = node->GetParent() == NULL;

@@ -623,7 +623,7 @@ void BrowserAccessibilityManagerAndroid::ScrollToMakeNodeVisible(

jint id) {

BrowserAccessibilityAndroid* node = GetFromUniqueID(id);

if (node)

- ScrollToMakeVisible(*node, gfx::Rect(node->GetLocation().size()));

+ ScrollToMakeVisible(*node, gfx::Rect(node->GetFrameBoundsRect().size()));

}

void BrowserAccessibilityManagerAndroid::SetTextFieldValue(